You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2014/11/16 16:30:11 UTC
[GitHub] incubator-flink pull request: [FLINK-1244] setCombinable() returns...
GitHub user zentol opened a pull request:
https://github.com/apache/incubator-flink/pull/205
[FLINK-1244] setCombinable() returns operator
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/incubator-flink set_combine_void
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/205.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #205
----
commit 1ab82ba2e6707d574362db8baf63c5a4b66fdfe6
Author: zentol <s....@web.de>
Date: 2014-11-16T15:28:28Z
[FLINK-1244] setCombinable() returns operator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1244] setCombinable() returns...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/205#issuecomment-63294764
Looks good.
I assume that this is breaking binary compatibility, though. Source compatibility is preserved.
+1 to merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1244] setCombinable() returns...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-flink/pull/205
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1244] setCombinable() returns...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/205#issuecomment-63272913
LGTM, good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---