[jira] [Commented] (CAMEL-12222) ResrSwaggerServlet removes last part of context root

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-12222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360028#comment-16360028 ] 

ASF GitHub Bot commented on CAMEL-12222:
----------------------------------------

DariusX opened a new pull request #2220: CAMEL-12222: RestSwaggerServlet - added option to suppress "translate…
URL: https://github.com/apache/camel/pull/2220
 
 
   Added an option to suppress "translateContextPath"
   Also, added a fix to allow this class to be used in the 2.20.1 version, even though it is deprecated

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ResrSwaggerServlet removes last part of context root
> ----------------------------------------------------
>
>                 Key: CAMEL-12222
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12222
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-swagger
>            Reporter: Darius Cooper
>            Priority: Minor
>
> The method within RestSwaggerServlet, looks for the last "/" in the context root, and drops anything after that slash.
> {code:java}
> private String translateContextPath(HttpServletRequest request) {
>   String path = request.getContextPath();
>   if (path.isEmpty() || path.equals("/")) {
>       return "";
>   } else {
>      int idx = path.lastIndexOf("/");
>      if (idx > 0) {
>          return path.substring(0, idx);
>      }
>   }
>   return path;
> }{code}
> Even though this has been deprecated, it would be good to fix it. 
> An approach could be to add a servlet init parameter named "translateContextPath" which would default to true, and would work exactly as it does today by default. if set to false, it would return whatever value is in request.getContextPath() , with no translation.
> Also, to avoid the NPE thrown, pass in an empty RestConfiguration to RestSwaggerSupport.renderResourceListing() 
> (See: https://issues.apache.org/jira/browse/CAMEL-12038) 
> I plan on working on this. Creating a Jira to get feedback on the approach



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)