You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/24 02:17:34 UTC
[GitHub] [arrow] fredgan opened a new pull request #7824: ARROW-9205: [Documentation] Fix typos
fredgan opened a new pull request #7824:
URL: https://github.com/apache/arrow/pull/7824
Minor issue. Reusing the old bugid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7824: ARROW-9205: [Documentation] Fix typos
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#issuecomment-663322595
https://issues.apache.org/jira/browse/ARROW-9205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fredgan commented on pull request #7824: ARROW-9205: [Documentation] Fix typos
Posted by GitBox <gi...@apache.org>.
fredgan commented on pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#issuecomment-670605044
@sbinet Hi, It's not about Go part, but I just fix some typos when I read the Document. Can you also help handle it? It's been a long time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on a change in pull request #7824: ARROW-9205: [Documentation] Fix typos
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on a change in pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#discussion_r459823837
##########
File path: docs/source/format/Flight.rst
##########
@@ -20,7 +20,7 @@
Arrow Flight RPC
================
-Arrow Flight is a RPC framework for high-performance data services
+Arrow Flight is an RPC framework for high-performance data services
Review comment:
Recalled mid school English quiz :)
Looks it should be "an", https://www.quora.com/Which-is-correct-in-English-an-R-or-a-R
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fredgan commented on a change in pull request #7824: ARROW-9205: [Documentation] Fix typos
Posted by GitBox <gi...@apache.org>.
fredgan commented on a change in pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#discussion_r460603801
##########
File path: docs/source/format/Columnar.rst
##########
@@ -76,7 +76,7 @@ concepts, here is a small glossary to help disambiguate.
* **Nested type**: a data type whose full structure depends on one or
more other child types. Two fully-specified nested types are equal
if and only if their child types are equal. For example, ``List<U>``
- is distinct from ``List<V>`` iff U and V are different types.
+ is distinct from ``List<V>`` if U and V are different types.
Review comment:
Hi, I think `if and noly if` seems a bit verbose because it appears in the line above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #7824: ARROW-9205: [Documentation] Fix typos
Posted by GitBox <gi...@apache.org>.
kou closed pull request #7824:
URL: https://github.com/apache/arrow/pull/7824
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #7824: ARROW-9205: [Documentation] Fix typos
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#discussion_r460444793
##########
File path: docs/source/format/Columnar.rst
##########
@@ -76,7 +76,7 @@ concepts, here is a small glossary to help disambiguate.
* **Nested type**: a data type whose full structure depends on one or
more other child types. Two fully-specified nested types are equal
if and only if their child types are equal. For example, ``List<U>``
- is distinct from ``List<V>`` iff U and V are different types.
+ is distinct from ``List<V>`` if U and V are different types.
Review comment:
"iff" is not a typo.
"iff" means "if and only if".
How about changing "iff" to "if and only if" not "if" like the previous sentence?
```suggestion
is distinct from ``List<V>`` if and only if U and V are different types.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #7824: ARROW-9205: [Documentation] Fix typos
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#discussion_r467259196
##########
File path: docs/source/format/Columnar.rst
##########
@@ -76,7 +76,7 @@ concepts, here is a small glossary to help disambiguate.
* **Nested type**: a data type whose full structure depends on one or
more other child types. Two fully-specified nested types are equal
if and only if their child types are equal. For example, ``List<U>``
- is distinct from ``List<V>`` iff U and V are different types.
+ is distinct from ``List<V>`` if U and V are different types.
Review comment:
I think that we should choose correctness than simpleness here because we explain specification here.
If we can keep this "iff", I can accept and merge this. If we can't, we need other commiter's review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #7824: ARROW-9205: [Documentation] Fix typos
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#discussion_r460444930
##########
File path: docs/source/format/Columnar.rst
##########
@@ -76,7 +76,7 @@ concepts, here is a small glossary to help disambiguate.
* **Nested type**: a data type whose full structure depends on one or
more other child types. Two fully-specified nested types are equal
if and only if their child types are equal. For example, ``List<U>``
- is distinct from ``List<V>`` iff U and V are different types.
+ is distinct from ``List<V>`` if U and V are different types.
Review comment:
If we include this change, we should change the PR title (this is not a typo).
If we don't include this change, we can keep the current PR title.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on pull request #7824: ARROW-9205: [Documentation] Fix typos
Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#issuecomment-663789181
May this PR include unrelated changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fredgan commented on pull request #7824: ARROW-9205: [Documentation] Fix typos
Posted by GitBox <gi...@apache.org>.
fredgan commented on pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#issuecomment-663821259
@kiszk Well, because the master branch history is changed by 88b767ba549de35bebe79c2b1b4bc3df8de1ac24
The old master branch history is different with the current. So the PR shows many other unrelated changes.
I rebase it to the current master branch. It's OK now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fredgan edited a comment on pull request #7824: ARROW-9205: [Documentation] Fix typos
Posted by GitBox <gi...@apache.org>.
fredgan edited a comment on pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#issuecomment-670422135
@wesm Hi Wes, do you have any option about this? if no, can you help handle it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fredgan commented on pull request #7824: ARROW-9205: [Documentation] Fix typos
Posted by GitBox <gi...@apache.org>.
fredgan commented on pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#issuecomment-670422135
@wesm Hi wes, do you have any option about this? if no, can you help handle it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fredgan edited a comment on pull request #7824: ARROW-9205: [Documentation] Fix typos
Posted by GitBox <gi...@apache.org>.
fredgan edited a comment on pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#issuecomment-663821259
@kiszk Well, because the master branch history is changed since 88b767ba549de35bebe79c2b1b4bc3df8de1ac24 by kszucs，
The old master branch history is different with the current. So the PR shows many other unrelated changes.
you can see the item above your comment.
I rebase it to the current master branch. It's OK now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fredgan commented on a change in pull request #7824: ARROW-9205: [Documentation] Fix typos
Posted by GitBox <gi...@apache.org>.
fredgan commented on a change in pull request #7824:
URL: https://github.com/apache/arrow/pull/7824#discussion_r467334354
##########
File path: docs/source/format/Columnar.rst
##########
@@ -76,7 +76,7 @@ concepts, here is a small glossary to help disambiguate.
* **Nested type**: a data type whose full structure depends on one or
more other child types. Two fully-specified nested types are equal
if and only if their child types are equal. For example, ``List<U>``
- is distinct from ``List<V>`` iff U and V are different types.
+ is distinct from ``List<V>`` if U and V are different types.
Review comment:
@kou Well, I give up the modification for `iff` now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org