You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "duhow (via GitHub)" <gi...@apache.org> on 2024/03/25 14:33:55 UTC

[PR] db: alter commit columns to binary type [incubator-devlake]

duhow opened a new pull request, #7212:
URL: https://github.com/apache/incubator-devlake/pull/7212

   ### Summary
   Migration schema for MySQL.
   - `commits.message` is now `CHARACTER SET binary`,
   - `commit_files.file_path` is now `VARBINARY`.
   
   The reason is to support ASCII-extended characters in both columns.
   
   ⚠️ NOTE: Migration for  `file_path` is slow, about 3 minutes for ~1.4 million records.
   
   ### Does this close any open issues?
   Fixes #7203
   Fixes #7198


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(db): alter commit columns to binary type [incubator-devlake]

Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #7212:
URL: https://github.com/apache/incubator-devlake/pull/7212#issuecomment-2042334984

   @duhow Thanks for your contribution. 😀


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(db): alter commit columns to binary type [incubator-devlake]

Posted by "duhow (via GitHub)" <gi...@apache.org>.
duhow commented on PR #7212:
URL: https://github.com/apache/incubator-devlake/pull/7212#issuecomment-2036795187

   @klesh I've updated the commit title, can you run the workflow again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(db): alter commit columns to binary type [incubator-devlake]

Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh merged PR #7212:
URL: https://github.com/apache/incubator-devlake/pull/7212


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org