You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/12/12 17:49:18 UTC
Review Request 64550: Made `update` return a future completed before
`forwardCallback`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64550/
-----------------------------------------------------------
Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
Repository: mesos
Description
-------
We maintain an ordering invariant that the completion of the future
returned by `update` happens before the invocation of `forwardCallback`.
This invariant provides the guarantee that if `forwardCallback` is
deferred to the same context as the chained callback of the returned
future, the latter will happen before the earlier. This is useful if
the caller of the status update manager want to maintain its internal
state after the manager checkpoints the status update but before the
status update is sent out.
Diffs
-----
src/status_update_manager/status_update_manager_process.hpp 1ac64410594134ce3e709d396d0a74a3d0aa2007
Diff: https://reviews.apache.org/r/64550/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 64550: Made `update` return a future completed
before `forwardCallback`.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64550/#review193581
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 12, 2017, 5:49 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64550/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 5:49 p.m.)
>
>
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We maintain an ordering invariant that the completion of the future
> returned by `update` happens before the invocation of `forwardCallback`.
> This invariant provides the guarantee that if `forwardCallback` is
> deferred to the same context as the chained callback of the returned
> future, the latter will happen before the earlier. This is useful if
> the caller of the status update manager want to maintain its internal
> state after the manager checkpoints the status update but before the
> status update is sent out.
>
>
> Diffs
> -----
>
> src/status_update_manager/status_update_manager_process.hpp 1ac64410594134ce3e709d396d0a74a3d0aa2007
>
>
> Diff: https://reviews.apache.org/r/64550/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64550: Made `update` return a future completed
before `forwardCallback`.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64550/#review193593
-----------------------------------------------------------
Fix it, then Ship it!
In the commit message: `s/This is useful if the caller of the status update manager want/This is useful if
the caller of the status update manager wants/`
src/status_update_manager/status_update_manager_process.hpp
Lines 513 (patched)
<https://reviews.apache.org/r/64550/#comment272161>
s/asynchoronus/asynchronous/
I'd put this comment right above the `dispatch` call.
- Gaston Kleiman
On Dec. 12, 2017, 9:49 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64550/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 9:49 a.m.)
>
>
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We maintain an ordering invariant that the completion of the future
> returned by `update` happens before the invocation of `forwardCallback`.
> This invariant provides the guarantee that if `forwardCallback` is
> deferred to the same context as the chained callback of the returned
> future, the latter will happen before the earlier. This is useful if
> the caller of the status update manager want to maintain its internal
> state after the manager checkpoints the status update but before the
> status update is sent out.
>
>
> Diffs
> -----
>
> src/status_update_manager/status_update_manager_process.hpp 1ac64410594134ce3e709d396d0a74a3d0aa2007
>
>
> Diff: https://reviews.apache.org/r/64550/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64550: Made `update` return a future completed
before `forwardCallback`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64550/#review193586
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64517', '64472', '64473', '64509', '64521', '64550']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64550
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64550/logs/mesos-tests-stdout.log):
```
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2412 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2437 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (3139 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (3162 ms total)
[----------] Global test environment tear-down
[==========] 830 tests from 84 test cases ran. (322308 ms total)
[ PASSED ] 819 tests.
[ FAILED ] 11 tests, listed below:
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateLatestWhenResending
[ FAILED ] SlaveTest.ResourceProviderPublishAll
11 FAILED TESTS
YOU HAVE 201 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64550/logs/mesos-tests-stderr.log):
```
I1212 18:41:56.392915 9544 master.cpp:10114] Updating the state of task d2e84fc2-29fe-4a26-8ad3-aae3fca54755 of framework eb15fa9d-8a4c-4edb-a501-24251020b202-0000 (latest state: TASK_KILLED,I1212 18:41:55.656930 7864 exec.cpp:162] Version: 1.5.0
I1212 18:41:55.680415 592 exec.cpp:237] Executor registered on agent eb15fa9d-8a4c-4edb-a501-24251020b202-S0
I1212 18:41:55.682927 5784 executor.cpp:171] Received SUBSCRIBED event
I1212 18:41:55.687929 5784 executor.cpp:175] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1212 18:41:55.687929 5784 executor.cpp:171] Received LAUNCH event
I1212 18:41:55.689929 5784 executor.cpp:637] Starting task d2e84fc2-29fe-4a26-8ad3-aae3fca54755
I1212 18:41:55.774929 5784 executor.cpp:477] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1212 18:41:56.365924 5784 executor.cpp:650] Forked command at 5840
I1212 18:41:56.394917 868 exec.cpp:435] Executor asked to shutdown
I1212 18:41:56.394917 5784 executor.cpp:171] Received SHUTDOWN event
I1212 18:41:56.394917 5784 executor.cpp:747] Shutting down
I1212 18:41:56.394917 5784 executor.cpp:854] Sending SIGTERM to process tree at pid 5 status update state: TASK_KILLED)
I1212 18:41:56.392915 7048 slave.cpp:3400] Shutting down framework eb15fa9d-8a4c-4edb-a501-24251020b202-0000
I1212 18:41:56.392915 7048 slave.cpp:6091] Shutting down executor 'd2e84fc2-29fe-4a26-8ad3-aae3fca54755' of framework eb15fa9d-8a4c-4edb-a501-24251020b202-0000 at executor(1)@10.3.1.11:49611
I1212 18:41:56.393916 7048 slave.cpp:909] Agent terminating
W1212 18:41:56.393916 7048 slave.cpp:3396] Ignoring shutdown framework eb15fa9d-8a4c-4edb-a501-24251020b202-0000 because it is terminating
I1212 18:41:56.394917 9544 master.cpp:10220] Removing task d2e84fc2-29fe-4a26-8ad3-aae3fca54755 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework eb15fa9d-8a4c-4edb-a501-24251020b202-0000 on agent eb15fa9d-8a4c-4edb-a501-24251020b202-S0 at slave(326)@10.3.1.11:49589 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1212 18:41:56.397920 2768 containerizer.cpp:2328] Destroying container e3ade64e-2326-4d7b-8ea4-b121a0a7f633 in RUNNING state
I1212 18:41:56.397920 9544 master.cpp:1305] Agent eb15fa9d-8a4c-4edb-a501-24251020b202-S0 at slave(326)@10.3.1.11:49589 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1212 18:41:56.397920 9544 master.cpp:3364] Disconnecting agent eb15fa9d-8a4c-4edb-a501-24251020b202-S0 at slave(326)@10.3.1.11:49589 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1212 18:41:56.397920 2768 containerizer.cpp:2930] Transitioning the state of container e3ade64e-2326-4d7b-8ea4-b121a0a7f633 from RUNNING to DESTROYING
I1212 18:41:56.397920 9544 master.cpp:3383] Deactivating agent eb15fa9d-8a4c-4edb-a501-24251020b202-S0 at slave(326)@10.3.1.11:49589 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1212 18:41:56.397920 2680 hierarchical.cpp:344] Removed framework eb15fa9d-8a4c-4edb-a501-24251020b202-0000
I1212 18:41:56.399197 2680 hierarchical.cpp:766] Agent eb15fa9d-8a4c-4edb-a501-24251020b202-S0 deactivated
I1212 18:41:56.399197 2768 launcher.cpp:156] Asked to destroy container e3ade64e-2326-4d7b-8ea4-b121a0a7f633
I1212 18:41:56.503868 2680 containerizer.cpp:2779] Container e3ade64e-2326-4d7b-8ea4-b121a0a7f633 has exited
I1212 18:41:56.531877 4124 master.cpp:1147] Master terminating
I1212 18:41:56.533877 9544 hierarchical.cpp:609] Removed agent eb15fa9d-8a4c-4edb-a501-24251020b202-S0
I1212 18:41:56.870877 1792 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 12, 2017, 9:49 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64550/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 9:49 a.m.)
>
>
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We maintain an ordering invariant that the completion of the future
> returned by `update` happens before the invocation of `forwardCallback`.
> This invariant provides the guarantee that if `forwardCallback` is
> deferred to the same context as the chained callback of the returned
> future, the latter will happen before the earlier. This is useful if
> the caller of the status update manager want to maintain its internal
> state after the manager checkpoints the status update but before the
> status update is sent out.
>
>
> Diffs
> -----
>
> src/status_update_manager/status_update_manager_process.hpp 1ac64410594134ce3e709d396d0a74a3d0aa2007
>
>
> Diff: https://reviews.apache.org/r/64550/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>