You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "James Page (JIRA)" <ji...@apache.org> on 2011/07/05 16:51:18 UTC
[jira] [Created] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
-----------------------------------------------------------------
Key: ZOOKEEPER-1117
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
Project: ZooKeeper
Issue Type: Bug
Components: c client
Affects Versions: 3.3.3
Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
Reporter: James Page
Priority: Minor
zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
/bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
src/zookeeper.c: In function 'getaddrs':
src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084931#comment-13084931 ]
Mahadev konar commented on ZOOKEEPER-1117:
------------------------------------------
James,
Any chance you are back and can update the patch?
> zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1117
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3, 3.4.0
> Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
> Reporter: James Page
> Assignee: James Page
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: disable-cc-errors, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-trunk-fix.patch
>
>
> zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
> src/zookeeper.c: In function 'getaddrs':
> src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
Posted by "James Page (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Page updated ZOOKEEPER-1117:
----------------------------------
Attachment: gcc-4.6-trunk-fix.patch
gcc 4.6 fix for trunk
> zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1117
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
> Reporter: James Page
> Priority: Minor
> Attachments: disable-cc-errors, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-trunk-fix.patch
>
>
> zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
> src/zookeeper.c: In function 'getaddrs':
> src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
Posted by "James Page (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080994#comment-13080994 ]
James Page commented on ZOOKEEPER-1117:
---------------------------------------
Please ignore last patch - still incorrect
> zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1117
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
> Reporter: James Page
> Priority: Minor
> Attachments: disable-cc-errors, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch
>
>
> zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
> src/zookeeper.c: In function 'getaddrs':
> src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
Posted by "James Page (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081126#comment-13081126 ]
James Page commented on ZOOKEEPER-1117:
---------------------------------------
Mahadev,
Same issue on trunk; attached reworked patch to this bug report.
> zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1117
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
> Reporter: James Page
> Priority: Minor
> Attachments: disable-cc-errors, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-trunk-fix.patch
>
>
> zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
> src/zookeeper.c: In function 'getaddrs':
> src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13091708#comment-13091708 ]
Hudson commented on ZOOKEEPER-1117:
-----------------------------------
Integrated in ZooKeeper-trunk #1283 (See [https://builds.apache.org/job/ZooKeeper-trunk/1283/])
ZOOKEEPER-1117. zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu (James Page via mahadev)
mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1162013
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/c/src/cli.c
* /zookeeper/trunk/src/c/src/zookeeper.c
> zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1117
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3, 3.4.0
> Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
> Reporter: James Page
> Assignee: James Page
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1117-3.3.3.patch, ZOOKEEPER-1117.patch, disable-cc-errors, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-trunk-fix.patch
>
>
> zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
> src/zookeeper.c: In function 'getaddrs':
> src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085608#comment-13085608 ]
Hadoop QA commented on ZOOKEEPER-1117:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12490512/ZOOKEEPER-1117-3.3.3.patch
against trunk revision 1157698.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/461//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/461//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/461//console
This message is automatically generated.
> zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1117
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3, 3.4.0
> Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
> Reporter: James Page
> Assignee: James Page
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1117-3.3.3.patch, ZOOKEEPER-1117.patch, disable-cc-errors, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-trunk-fix.patch
>
>
> zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
> src/zookeeper.c: In function 'getaddrs':
> src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081051#comment-13081051 ]
Mahadev konar commented on ZOOKEEPER-1117:
------------------------------------------
James,
Is this the issue with trunk as well? Can you please check and confirm? If yes, would you be able to upload a patch for trunk as well?
> zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1117
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
> Reporter: James Page
> Priority: Minor
> Attachments: disable-cc-errors, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch
>
>
> zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
> src/zookeeper.c: In function 'getaddrs':
> src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
Posted by "James Page (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Page updated ZOOKEEPER-1117:
----------------------------------
Attachment: disable-cc-errors
> zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1117
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
> Reporter: James Page
> Priority: Minor
> Attachments: disable-cc-errors
>
>
> zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
> src/zookeeper.c: In function 'getaddrs':
> src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
Posted by "Stephen Tyree (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13060021#comment-13060021 ]
Stephen Tyree commented on ZOOKEEPER-1117:
------------------------------------------
That warning exists for a good reason, and marking it not as an error is only glosses over the problem. A better solution would be to move the code which initializes port into the block that only runs on Cygwin since that's where it's used.
> zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1117
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
> Reporter: James Page
> Priority: Minor
> Attachments: disable-cc-errors
>
>
> zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
> src/zookeeper.c: In function 'getaddrs':
> src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
Posted by "James Page (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Page updated ZOOKEEPER-1117:
----------------------------------
Attachment: gcc-4.6-ftbfs.patch
> zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1117
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
> Reporter: James Page
> Priority: Minor
> Attachments: disable-cc-errors, gcc-4.6-ftbfs.patch
>
>
> zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
> src/zookeeper.c: In function 'getaddrs':
> src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1117:
------------------------------------
Affects Version/s: 3.4.0
Fix Version/s: 3.4.0
3.3.4
> zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1117
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3, 3.4.0
> Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
> Reporter: James Page
> Assignee: James Page
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: disable-cc-errors, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-trunk-fix.patch
>
>
> zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
> src/zookeeper.c: In function 'getaddrs':
> src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
Posted by "James Page (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Page updated ZOOKEEPER-1117:
----------------------------------
Attachment: ZOOKEEPER-1117-3.3.3.patch
ZOOKEEPER-1117.patch
Patches for trunk and 3.3.x branch
> zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1117
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3, 3.4.0
> Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
> Reporter: James Page
> Assignee: James Page
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1117-3.3.3.patch, ZOOKEEPER-1117.patch, disable-cc-errors, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-trunk-fix.patch
>
>
> zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
> src/zookeeper.c: In function 'getaddrs':
> src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
Posted by "James Page (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Page updated ZOOKEEPER-1117:
----------------------------------
Attachment: gcc-4.6-ftbfs.patch
> zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1117
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
> Reporter: James Page
> Priority: Minor
> Attachments: disable-cc-errors, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch
>
>
> zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
> src/zookeeper.c: In function 'getaddrs':
> src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
Posted by "James Page (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083511#comment-13083511 ]
James Page commented on ZOOKEEPER-1117:
---------------------------------------
Hi Patrick - will do but I'm out for the next few days to likely to be later next week.
> zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1117
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3, 3.4.0
> Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
> Reporter: James Page
> Assignee: James Page
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: disable-cc-errors, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-trunk-fix.patch
>
>
> zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
> src/zookeeper.c: In function 'getaddrs':
> src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081274#comment-13081274 ]
Patrick Hunt commented on ZOOKEEPER-1117:
-----------------------------------------
Hi James, thanks for this! Could you re-attach your patches with "ASF Granted License" checked? If you look at "manage attachments" in jira
https://issues.apache.org/jira/secure/ManageAttachments.jspa?atl_token=A5KQ-2QAV-T4JA-FDED|7da8d16caa4119bb0c4c4d3190971590529a6b25|lin&id=12512864
your patches are listed as "no", which means we can't incorporate. (alternately you could just add a comment to the effect that you grant, but re-attaching the patches with the "grant" checkbox checked would be better).
more details here:
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
Also, once your patch is ready click on "submit patch" to start it moving through the process (ie the test bot will run (down at the moment) and committer can review)
Regards.
> zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1117
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3, 3.4.0
> Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
> Reporter: James Page
> Assignee: James Page
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: disable-cc-errors, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-trunk-fix.patch
>
>
> zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
> src/zookeeper.c: In function 'getaddrs':
> src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
Posted by "James Page (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Page updated ZOOKEEPER-1117:
----------------------------------
Attachment: gcc-4.6-ftbfs.patch
Revised patch to detect file descriptors read for r/w activity
> zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1117
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
> Reporter: James Page
> Priority: Minor
> Attachments: disable-cc-errors, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch
>
>
> zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
> src/zookeeper.c: In function 'getaddrs':
> src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1117) zookeeper 3.3.3 fails to build
with gcc >= 4.6.1 on Debian/Ubuntu
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-1117:
---------------------------------------
Assignee: James Page
> zookeeper 3.3.3 fails to build with gcc >= 4.6.1 on Debian/Ubuntu
> -----------------------------------------------------------------
>
> Key: ZOOKEEPER-1117
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1117
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3, 3.4.0
> Environment: Ubuntu Developement Release (11.10/Oneiric Ocelot), Debian Unstable (sid)
> Reporter: James Page
> Assignee: James Page
> Priority: Minor
> Fix For: 3.3.4, 3.4.0
>
> Attachments: disable-cc-errors, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-ftbfs.patch, gcc-4.6-trunk-fix.patch
>
>
> zookeeper 3.3.3 (and 3.3.1) fails to build on Debian and Ubuntu systems with gcc >= 4.6.1:
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fPIC -DPIC -o .libs/zookeeper.o
> src/zookeeper.c: In function 'getaddrs':
> src/zookeeper.c:455:13: error: variable 'port' set but not used [-Werror=unused-but-set-variable]
> cc1: all warnings being treated as errors
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625441 for more information.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira