You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "amanraj2520 (via GitHub)" <gi...@apache.org> on 2023/09/20 17:33:07 UTC
[GitHub] [hive] amanraj2520 opened a new pull request, #4729: HIVE-27715 : Backport of HIVE-25235: Remove ThreadPoolExecutorWithOomHook to branch-3
amanraj2520 opened a new pull request, #4729:
URL: https://github.com/apache/hive/pull/4729
JIRA link - HIVE-27715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] amanraj2520 commented on a diff in pull request #4729: HIVE-27715 : Backport of HIVE-25235: Remove ThreadPoolExecutorWithOomHook to branch-3
Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on code in PR #4729:
URL: https://github.com/apache/hive/pull/4729#discussion_r1333311896
##########
service/src/java/org/apache/hive/service/server/HiveServer2.java:
##########
@@ -217,9 +217,9 @@ public void run() {
}
};
if (isHTTPTransportMode(hiveConf)) {
- thriftCLIService = new ThriftHttpCLIService(cliService, oomHook);
+ thriftCLIService = new ThriftHttpCLIService(cliService);
Review Comment:
Done this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sankarh commented on a diff in pull request #4729: HIVE-27715 : Backport of HIVE-25235: Remove ThreadPoolExecutorWithOomHook to branch-3
Posted by "sankarh (via GitHub)" <gi...@apache.org>.
sankarh commented on code in PR #4729:
URL: https://github.com/apache/hive/pull/4729#discussion_r1333305827
##########
service/src/java/org/apache/hive/service/server/HiveServer2.java:
##########
@@ -217,9 +217,9 @@ public void run() {
}
};
if (isHTTPTransportMode(hiveConf)) {
- thriftCLIService = new ThriftHttpCLIService(cliService, oomHook);
+ thriftCLIService = new ThriftHttpCLIService(cliService);
Review Comment:
Remove the definition of oomHook as it is not used anywhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sankarh merged pull request #4729: HIVE-27715 : Backport of HIVE-25235: Remove ThreadPoolExecutorWithOomHook to branch-3
Posted by "sankarh (via GitHub)" <gi...@apache.org>.
sankarh merged PR #4729:
URL: https://github.com/apache/hive/pull/4729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org