You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by wr...@apache.org on 2007/05/31 21:09:29 UTC
svn commit: r543219 - in /apr/apr/trunk/include: apr.hw
arch/win32/apr_private.h
Author: wrowe
Date: Thu May 31 12:09:28 2007
New Revision: 543219
URL: http://svn.apache.org/viewvc?view=rev&rev=543219
Log:
Stop undefining __attribute__ for GNUC (only 2.7 and prior might be interesting, and can't
think of any case where native win32 binaries would be created with such an ancient compiler.)
PR: 42545
Modified:
apr/apr/trunk/include/apr.hw
apr/apr/trunk/include/arch/win32/apr_private.h
Modified: apr/apr/trunk/include/apr.hw
URL: http://svn.apache.org/viewvc/apr/apr/trunk/include/apr.hw?view=diff&rev=543219&r1=543218&r2=543219
==============================================================================
--- apr/apr/trunk/include/apr.hw (original)
+++ apr/apr/trunk/include/apr.hw Thu May 31 12:09:28 2007
@@ -113,7 +113,7 @@
#define APR_INLINE __inline
#define APR_HAS_INLINE 1
-#ifndef __attribute__
+#if !defined(__GNUC__) && !defined(__attribute__)
#define __attribute__(__x)
#endif
Modified: apr/apr/trunk/include/arch/win32/apr_private.h
URL: http://svn.apache.org/viewvc/apr/apr/trunk/include/arch/win32/apr_private.h?view=diff&rev=543219&r1=543218&r2=543219
==============================================================================
--- apr/apr/trunk/include/arch/win32/apr_private.h (original)
+++ apr/apr/trunk/include/arch/win32/apr_private.h Thu May 31 12:09:28 2007
@@ -114,8 +114,6 @@
#define SIGWINCH 30
#define SIGIO 31
-#define __attribute__(__x)
-
/* APR COMPATABILITY FUNCTIONS
* This section should be used to define functions and
* macros which are need to make Windows features look
Re: svn commit: r543219 - in /apr/apr/trunk/include: apr.hw arch/win32/apr_private.h
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At least a second set of eyeballs please before I close this on 1.2/0.9?
apr.h is included prior to apr_private.h - the second was redundant.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42545
wrowe@apache.org wrote:
> Author: wrowe
> Date: Thu May 31 12:09:28 2007
> New Revision: 543219
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=543219
> Log:
> Stop undefining __attribute__ for GNUC (only 2.7 and prior might be interesting, and can't
> think of any case where native win32 binaries would be created with such an ancient compiler.)
>
> PR: 42545
>
> Modified:
> apr/apr/trunk/include/apr.hw
> apr/apr/trunk/include/arch/win32/apr_private.h
>
> Modified: apr/apr/trunk/include/apr.hw
> URL: http://svn.apache.org/viewvc/apr/apr/trunk/include/apr.hw?view=diff&rev=543219&r1=543218&r2=543219
> ==============================================================================
> --- apr/apr/trunk/include/apr.hw (original)
> +++ apr/apr/trunk/include/apr.hw Thu May 31 12:09:28 2007
> @@ -113,7 +113,7 @@
>
> #define APR_INLINE __inline
> #define APR_HAS_INLINE 1
> -#ifndef __attribute__
> +#if !defined(__GNUC__) && !defined(__attribute__)
> #define __attribute__(__x)
> #endif
>
>
> Modified: apr/apr/trunk/include/arch/win32/apr_private.h
> URL: http://svn.apache.org/viewvc/apr/apr/trunk/include/arch/win32/apr_private.h?view=diff&rev=543219&r1=543218&r2=543219
> ==============================================================================
> --- apr/apr/trunk/include/arch/win32/apr_private.h (original)
> +++ apr/apr/trunk/include/arch/win32/apr_private.h Thu May 31 12:09:28 2007
> @@ -114,8 +114,6 @@
> #define SIGWINCH 30
> #define SIGIO 31
>
> -#define __attribute__(__x)
> -
> /* APR COMPATABILITY FUNCTIONS
> * This section should be used to define functions and
> * macros which are need to make Windows features look
>
>
>
>
Re: svn commit: r543219 - in /apr/apr/trunk/include: apr.hw arch/win32/apr_private.h
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At least a second set of eyeballs please before I close this on 1.2/0.9?
apr.h is included prior to apr_private.h - the second was redundant.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42545
wrowe@apache.org wrote:
> Author: wrowe
> Date: Thu May 31 12:09:28 2007
> New Revision: 543219
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=543219
> Log:
> Stop undefining __attribute__ for GNUC (only 2.7 and prior might be interesting, and can't
> think of any case where native win32 binaries would be created with such an ancient compiler.)
>
> PR: 42545
>
> Modified:
> apr/apr/trunk/include/apr.hw
> apr/apr/trunk/include/arch/win32/apr_private.h
>
> Modified: apr/apr/trunk/include/apr.hw
> URL: http://svn.apache.org/viewvc/apr/apr/trunk/include/apr.hw?view=diff&rev=543219&r1=543218&r2=543219
> ==============================================================================
> --- apr/apr/trunk/include/apr.hw (original)
> +++ apr/apr/trunk/include/apr.hw Thu May 31 12:09:28 2007
> @@ -113,7 +113,7 @@
>
> #define APR_INLINE __inline
> #define APR_HAS_INLINE 1
> -#ifndef __attribute__
> +#if !defined(__GNUC__) && !defined(__attribute__)
> #define __attribute__(__x)
> #endif
>
>
> Modified: apr/apr/trunk/include/arch/win32/apr_private.h
> URL: http://svn.apache.org/viewvc/apr/apr/trunk/include/arch/win32/apr_private.h?view=diff&rev=543219&r1=543218&r2=543219
> ==============================================================================
> --- apr/apr/trunk/include/arch/win32/apr_private.h (original)
> +++ apr/apr/trunk/include/arch/win32/apr_private.h Thu May 31 12:09:28 2007
> @@ -114,8 +114,6 @@
> #define SIGWINCH 30
> #define SIGIO 31
>
> -#define __attribute__(__x)
> -
> /* APR COMPATABILITY FUNCTIONS
> * This section should be used to define functions and
> * macros which are need to make Windows features look
>
>
>
>