You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/12/22 14:19:33 UTC
[GitHub] [daffodil] jadams-tresys opened a new pull request, #899: Fixed issue where text alignment was expected for enum
jadams-tresys opened a new pull request, #899:
URL: https://github.com/apache/daffodil/pull/899
This small change checks against the repElement (the dfdx:repType) instead of the represented element in the enumeration (typically a string).
In the past we would typically expect the alignment to line up with whatever encoding was used for strings, but when using 1-bit alignment, daffodil wouuld complain about the strings being unaligned even though they are internally represented by something other than a string that is 1-bit aligned.
Now we check to see what kind of representation (text or binary) the repElement is and check alignment based on that.
DAFFODIL-2596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] jadams-tresys merged pull request #899: Fixed issue where text alignment was expected for enum
Posted by GitBox <gi...@apache.org>.
jadams-tresys merged PR #899:
URL: https://github.com/apache/daffodil/pull/899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] jadams-tresys commented on pull request #899: Fixed issue where text alignment was expected for enum
Posted by GitBox <gi...@apache.org>.
jadams-tresys commented on PR #899:
URL: https://github.com/apache/daffodil/pull/899#issuecomment-1362895816
There may be other areas where repElement should be used in this code, but this definitely fixes the alignment issues that Mike B was seeing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org