You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2013/06/06 13:32:38 UTC
svn commit: r1490241 - in /commons/proper/net/trunk/src: changes/changes.xml
main/java/org/apache/commons/net/telnet/TelnetInputStream.java
Author: sebb
Date: Thu Jun 6 11:32:38 2013
New Revision: 1490241
URL: http://svn.apache.org/r1490241
Log:
NET-501 Race Condition on TelnetClient.disconnect() and TelnetInputStream.run()
Modified:
commons/proper/net/trunk/src/changes/changes.xml
commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java
Modified: commons/proper/net/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/changes/changes.xml?rev=1490241&r1=1490240&r2=1490241&view=diff
==============================================================================
--- commons/proper/net/trunk/src/changes/changes.xml (original)
+++ commons/proper/net/trunk/src/changes/changes.xml Thu Jun 6 11:32:38 2013
@@ -65,6 +65,10 @@ The <action> type attribute can be add,u
<release version="3.3" date="2013-06-??" description="
This is a bug-fix release. See further details below.
">
+ <action issue="NET-501" dev="sebb" due-to="Julián Lastiri" type="fix">
+ Race Condition on TelnetClient.disconnect() and TelnetInputStream.run()
+ java.lang.IllegalStateException: Queue is full! Cannot process another character.
+ </action>
<action issue="NET-505" dev="sebb" due-to="Sean Kelley" type="update">
User specified bufferSize reset to default when FTPClient is disconnected or reinitialized resulting in performance degradation.
</action>
Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java?rev=1490241&r1=1490240&r2=1490241&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java Thu Jun 6 11:32:38 2013
@@ -594,7 +594,6 @@ final class TelnetInputStream extends Bu
__queue.notifyAll();
}
- __threaded = false;
}
// @Override
Re: svn commit: r1490241 - in /commons/proper/net/trunk/src:
changes/changes.xml main/java/org/apache/commons/net/telnet/TelnetInputStream.java
Posted by sebb <se...@gmail.com>.
On 6 June 2013 13:41, Jörg Schaible <Jo...@scalaris.com> wrote:
> sebb wrote:
>
>> On 6 June 2013 12:42, Benedikt Ritter <br...@apache.org> wrote:
>>> Hi Sebb,
>>>
>>>
>>> 2013/6/6 <se...@apache.org>
>>>
>>>> Author: sebb
>>>> Date: Thu Jun 6 11:32:38 2013
>>>> New Revision: 1490241
>>>>
>>>> URL: http://svn.apache.org/r1490241
>>>> Log:
>>>> NET-501 Race Condition on TelnetClient.disconnect() and
>>>> TelnetInputStream.run()
>>>>
>>>> Modified:
>>>> commons/proper/net/trunk/src/changes/changes.xml
>>>>
>>>>
> commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java
>>>>
>>>> Modified: commons/proper/net/trunk/src/changes/changes.xml
>>>> URL:
>>>>
> http://svn.apache.org/viewvc/commons/proper/net/trunk/src/changes/changes.xml?rev=1490241&r1=1490240&r2=1490241&view=diff
>>>>
>>>>
> ==============================================================================
>>>> --- commons/proper/net/trunk/src/changes/changes.xml (original)
>>>> +++ commons/proper/net/trunk/src/changes/changes.xml Thu Jun 6 11:32:38
>>>> 2013
>>>> @@ -65,6 +65,10 @@ The <action> type attribute can be add,u
>>>> <release version="3.3" date="2013-06-??" description="
>>>> This is a bug-fix release. See further details below.
>>>> ">
>>>> + <action issue="NET-501" dev="sebb" due-to="Julián Lastiri"
>>>> type="fix">
>>>>
>>>
>>> This looks like an encoding error. Or is it just a problem with ezmlm?
>>>
>>
>> Neither; I think it's a problem with the SVN charset not being defined
I meant the content charset.
See
URL: http://svn.apache.org/r1490243
Log:
Fix charset so commit mails look OK
> No. Subversion does not manage the encoding of the stored files. It's simple
> shit in => shit out. According the header of the file, its encoding is UTF-8
> (see XML spec). It seems its content does not match the declaration ;-)
The content did/does match the encoding (looks OK in Eclipse with
UTF-8 encoding), but SVN or its scripts was not creating the mail
appropriately.
It is now.
> - Jörg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1490241 - in /commons/proper/net/trunk/src: changes/changes.xml main/java/org/apache/commons/net/telnet/TelnetInputStream.java
Posted by Jörg Schaible <Jo...@scalaris.com>.
sebb wrote:
> On 6 June 2013 12:42, Benedikt Ritter <br...@apache.org> wrote:
>> Hi Sebb,
>>
>>
>> 2013/6/6 <se...@apache.org>
>>
>>> Author: sebb
>>> Date: Thu Jun 6 11:32:38 2013
>>> New Revision: 1490241
>>>
>>> URL: http://svn.apache.org/r1490241
>>> Log:
>>> NET-501 Race Condition on TelnetClient.disconnect() and
>>> TelnetInputStream.run()
>>>
>>> Modified:
>>> commons/proper/net/trunk/src/changes/changes.xml
>>>
>>>
commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java
>>>
>>> Modified: commons/proper/net/trunk/src/changes/changes.xml
>>> URL:
>>>
http://svn.apache.org/viewvc/commons/proper/net/trunk/src/changes/changes.xml?rev=1490241&r1=1490240&r2=1490241&view=diff
>>>
>>>
==============================================================================
>>> --- commons/proper/net/trunk/src/changes/changes.xml (original)
>>> +++ commons/proper/net/trunk/src/changes/changes.xml Thu Jun 6 11:32:38
>>> 2013
>>> @@ -65,6 +65,10 @@ The <action> type attribute can be add,u
>>> <release version="3.3" date="2013-06-??" description="
>>> This is a bug-fix release. See further details below.
>>> ">
>>> + <action issue="NET-501" dev="sebb" due-to="Julián Lastiri"
>>> type="fix">
>>>
>>
>> This looks like an encoding error. Or is it just a problem with ezmlm?
>>
>
> Neither; I think it's a problem with the SVN charset not being defined
No. Subversion does not manage the encoding of the stored files. It's simple
shit in => shit out. According the header of the file, its encoding is UTF-8
(see XML spec). It seems its content does not match the declaration ;-)
- Jörg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1490241 - in /commons/proper/net/trunk/src:
changes/changes.xml main/java/org/apache/commons/net/telnet/TelnetInputStream.java
Posted by sebb <se...@gmail.com>.
On 6 June 2013 12:42, Benedikt Ritter <br...@apache.org> wrote:
> Hi Sebb,
>
>
> 2013/6/6 <se...@apache.org>
>
>> Author: sebb
>> Date: Thu Jun 6 11:32:38 2013
>> New Revision: 1490241
>>
>> URL: http://svn.apache.org/r1490241
>> Log:
>> NET-501 Race Condition on TelnetClient.disconnect() and
>> TelnetInputStream.run()
>>
>> Modified:
>> commons/proper/net/trunk/src/changes/changes.xml
>>
>> commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java
>>
>> Modified: commons/proper/net/trunk/src/changes/changes.xml
>> URL:
>> http://svn.apache.org/viewvc/commons/proper/net/trunk/src/changes/changes.xml?rev=1490241&r1=1490240&r2=1490241&view=diff
>>
>> ==============================================================================
>> --- commons/proper/net/trunk/src/changes/changes.xml (original)
>> +++ commons/proper/net/trunk/src/changes/changes.xml Thu Jun 6 11:32:38
>> 2013
>> @@ -65,6 +65,10 @@ The <action> type attribute can be add,u
>> <release version="3.3" date="2013-06-??" description="
>> This is a bug-fix release. See further details below.
>> ">
>> + <action issue="NET-501" dev="sebb" due-to="Julián Lastiri"
>> type="fix">
>>
>
> This looks like an encoding error. Or is it just a problem with ezmlm?
>
Neither; I think it's a problem with the SVN charset not being defined
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1490241 - in /commons/proper/net/trunk/src:
changes/changes.xml main/java/org/apache/commons/net/telnet/TelnetInputStream.java
Posted by Benedikt Ritter <br...@apache.org>.
Hi Sebb,
2013/6/6 <se...@apache.org>
> Author: sebb
> Date: Thu Jun 6 11:32:38 2013
> New Revision: 1490241
>
> URL: http://svn.apache.org/r1490241
> Log:
> NET-501 Race Condition on TelnetClient.disconnect() and
> TelnetInputStream.run()
>
> Modified:
> commons/proper/net/trunk/src/changes/changes.xml
>
> commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java
>
> Modified: commons/proper/net/trunk/src/changes/changes.xml
> URL:
> http://svn.apache.org/viewvc/commons/proper/net/trunk/src/changes/changes.xml?rev=1490241&r1=1490240&r2=1490241&view=diff
>
> ==============================================================================
> --- commons/proper/net/trunk/src/changes/changes.xml (original)
> +++ commons/proper/net/trunk/src/changes/changes.xml Thu Jun 6 11:32:38
> 2013
> @@ -65,6 +65,10 @@ The <action> type attribute can be add,u
> <release version="3.3" date="2013-06-??" description="
> This is a bug-fix release. See further details below.
> ">
> + <action issue="NET-501" dev="sebb" due-to="Julián Lastiri"
> type="fix">
>
This looks like an encoding error. Or is it just a problem with ezmlm?
> + Race Condition on TelnetClient.disconnect() and
> TelnetInputStream.run()
> + java.lang.IllegalStateException: Queue is full! Cannot
> process another character.
> + </action>
> <action issue="NET-505" dev="sebb" due-to="Sean Kelley"
> type="update">
> User specified bufferSize reset to default when FTPClient is
> disconnected or reinitialized resulting in performance degradation.
> </action>
>
> Modified:
> commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java?rev=1490241&r1=1490240&r2=1490241&view=diff
>
> ==============================================================================
> ---
> commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java
> (original)
> +++
> commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java
> Thu Jun 6 11:32:38 2013
> @@ -594,7 +594,6 @@ final class TelnetInputStream extends Bu
> __queue.notifyAll();
> }
>
> - __threaded = false;
> }
>
> // @Override
>
>
>
--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter