You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/12/17 16:29:03 UTC
[GitHub] [iceberg-docs] InvisibleProgrammer opened a new pull request, #191: Fix sidebar
InvisibleProgrammer opened a new pull request, #191:
URL: https://github.com/apache/iceberg-docs/pull/191
Reason and sample screenshots: https://github.com/apache/iceberg/issues/6381
This provides a fix for an issue in that the sidebar menu completely disappears from the documentation side on a resolution that is lower than 1280px.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] InvisibleProgrammer commented on pull request #191: Fix sidebar
Posted by GitBox <gi...@apache.org>.
InvisibleProgrammer commented on PR #191:
URL: https://github.com/apache/iceberg-docs/pull/191#issuecomment-1382031000
@samredai : thx for the approve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] RussellSpitzer commented on pull request #191: Fix sidebar
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on PR #191:
URL: https://github.com/apache/iceberg-docs/pull/191#issuecomment-1382043820
Thanks for the review @samredai and thank you @InvisibleProgrammer for the pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] RussellSpitzer merged pull request #191: Fix sidebar
Posted by GitBox <gi...@apache.org>.
RussellSpitzer merged PR #191:
URL: https://github.com/apache/iceberg-docs/pull/191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] samredai commented on a diff in pull request #191: Fix sidebar
Posted by GitBox <gi...@apache.org>.
samredai commented on code in PR #191:
URL: https://github.com/apache/iceberg-docs/pull/191#discussion_r1066430770
##########
iceberg-theme/static/css/iceberg-theme.css:
##########
@@ -370,10 +370,6 @@ i.fa.fa-chevron-down {
}
}
-@media screen and (max-width: 1280px) {
Review Comment:
Instead of removing this completely, should we maybe decrease the width? At 768px the hamburger appears in the top-left that allows opening/closing the side menu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] InvisibleProgrammer commented on pull request #191: Fix sidebar
Posted by GitBox <gi...@apache.org>.
InvisibleProgrammer commented on PR #191:
URL: https://github.com/apache/iceberg-docs/pull/191#issuecomment-1368515193
@RussellSpitzer , what do you think about that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org