You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "choucmei (via GitHub)" <gi...@apache.org> on 2023/05/23 09:39:42 UTC
[GitHub] [seatunnel] choucmei opened a new pull request, #4812: [Bug] [JDBC Connector] JDBC Source lost data,when the data of partition_column is null. #4732
choucmei opened a new pull request, #4812:
URL: https://github.com/apache/seatunnel/pull/4812
…ull.
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] EricJoy2048 commented on pull request #4812: [Bugfix] [connector-jdbc] Fix when type is int and null value will always get 0 instead of null
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 commented on PR #4812:
URL: https://github.com/apache/seatunnel/pull/4812#issuecomment-1717166814
LGTM, Should you add e2e test to test this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] ic4y commented on pull request #4812: [Bugfix] [connector-jdbc] Fix when type is int and null value will always get 0 instead of null
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on PR #4812:
URL: https://github.com/apache/seatunnel/pull/4812#issuecomment-1666494457
@EricJoy2048 Can you help figure out why there's no CI/CD?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Bugfix] [connector-jdbc] Fix when type is int and null value will always get 0 instead of null [seatunnel]
Posted by "choucmei (via GitHub)" <gi...@apache.org>.
choucmei closed pull request #4812: [Bugfix] [connector-jdbc] Fix when type is int and null value will always get 0 instead of null
URL: https://github.com/apache/seatunnel/pull/4812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] choucmei commented on pull request #4812: [Bugfix] [connector-jdbc] Fix when type is int and null value will always get 0 instead of null
Posted by "choucmei (via GitHub)" <gi...@apache.org>.
choucmei commented on PR #4812:
URL: https://github.com/apache/seatunnel/pull/4812#issuecomment-1717770029
> LGTM, Should you add e2e test to test this pr?
> LGTM, Should you add e2e test to test this pr?
I will add e2e testing as soon as possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] EricJoy2048 commented on pull request #4812: [Bug] [JDBC Connector] JDBC Source lost data,when the data of partition_column is null. #4732
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 commented on PR #4812:
URL: https://github.com/apache/seatunnel/pull/4812#issuecomment-1558927939
What problem is this PR trying to solve? Do you need to modify the title?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] ic4y closed pull request #4812: [Bugfix] [connector-jdbc] Fix when type is int and null value will always get 0 instead of null
Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y closed pull request #4812: [Bugfix] [connector-jdbc] Fix when type is int and null value will always get 0 instead of null
URL: https://github.com/apache/seatunnel/pull/4812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Bugfix] [connector-jdbc] Fix when type is int and null value will always get 0 instead of null [seatunnel]
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #4812:
URL: https://github.com/apache/seatunnel/pull/4812#issuecomment-1758970904
Please check ci error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] EricJoy2048 commented on pull request #4812: [Bugfix] [connector-jdbc] Fix when type is int and null value will always get 0 instead of null
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 commented on PR #4812:
URL: https://github.com/apache/seatunnel/pull/4812#issuecomment-1713563407
Please fix CI error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] choucmei commented on pull request #4812: [Bug] [JDBC Connector] JDBC Source lost data,when the data of partition_column is null. #4732
Posted by "choucmei (via GitHub)" <gi...@apache.org>.
choucmei commented on PR #4812:
URL: https://github.com/apache/seatunnel/pull/4812#issuecomment-1558921477
This PR was blocked by e2e because mysql e2e was losing data.
https://github.com/apache/seatunnel/issues/4732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] EricJoy2048 closed pull request #4812: [Bugfix] [connector-jdbc] Fix when type is int and null value will always get 0 instead of null
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 closed pull request #4812: [Bugfix] [connector-jdbc] Fix when type is int and null value will always get 0 instead of null
URL: https://github.com/apache/seatunnel/pull/4812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org