You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/11/11 10:44:59 UTC
[GitHub] [helix] bfreuden opened a new pull request #1527: Bug 1516
bfreuden opened a new pull request #1527:
URL: https://github.com/apache/helix/pull/1527
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Resolves #1516
### Description
- [x ] Here are some details about my PR, including screenshots of any UI changes:
I fixed some compilation and executions errors in code samples delivered in the tutorial documentation.
I also added the following comment (about creating a state model) since I think it might help beginners like me.
But it should be reviewed by an Helix expert (and English native speaker):
```java
// Define your own states: those are opaque strings to Helix
// Only the topology of the state machine (initial state, transitions, priorities, final DROPPED state) is meaningful to Helix
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] bfreuden commented on pull request #1527: Compilation and execution errors in tutorial doc page
Posted by GitBox <gi...@apache.org>.
bfreuden commented on pull request #1527:
URL: https://github.com/apache/helix/pull/1527#issuecomment-728301821
@narendly I'm afraid I'm not sure I understand this (from https://github.com/apache/helix/wiki/Pull-Request-Merge-Steps):
_If this is the case, you must include one final commit message for the squashed commit in your final comment._
Should I simply leave a final comment like this?
> This ** is ready to be merged.
> fixed bug #1516: Tutorial doc page leads to compilation and execution errors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #1527: Compilation and execution errors in tutorial doc page
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1527:
URL: https://github.com/apache/helix/pull/1527#issuecomment-729304171
@bfreuden Thanks for the PR. Usually, we do squash and merge. So it would be helpful if you write down the final comment for the merged commit. So that we don't put anything wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on pull request #1527: Bug 1516
Posted by GitBox <gi...@apache.org>.
narendly commented on pull request #1527:
URL: https://github.com/apache/helix/pull/1527#issuecomment-727656772
@bfreuden thanks. could you please rename the PR title so that it's descriptive?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang merged pull request #1527: Compilation and execution errors in tutorial doc page
Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #1527:
URL: https://github.com/apache/helix/pull/1527
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] bfreuden commented on pull request #1527: Compilation and execution errors in tutorial doc page
Posted by GitBox <gi...@apache.org>.
bfreuden commented on pull request #1527:
URL: https://github.com/apache/helix/pull/1527#issuecomment-730188344
@jiajunwang Thank you too for taking care of it.
I'm truly sorry but I don't understand the procedure regarding the final commit message for squashed commits (from https://github.com/apache/helix/wiki/Pull-Request-Merge-Steps).
So just to be sure for next time (and sorry for asking the question twice): should I've simply had left a final PR comment like this?
> This PR is ready to be merged.
fixed bug #1516: Tutorial doc page leads to compilation and execution errors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] bfreuden commented on pull request #1527: Compilation and execution errors in tutorial doc page
Posted by GitBox <gi...@apache.org>.
bfreuden commented on pull request #1527:
URL: https://github.com/apache/helix/pull/1527#issuecomment-728295516
@narendly You're right! I've renamed the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org