You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/08 12:34:32 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #3075: [Minor] run cargo update in datafusion-cli directory
alamb opened a new pull request, #3075:
URL: https://github.com/apache/arrow-datafusion/pull/3075
# Which issue does this PR close?
N/A
# Rationale for this change
Keep datafusion-cli packages up to date
# What changes are included in this PR?
1. Check in the results of running `cargo update` in the `datafusion-cli` directory
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3075: [Minor] run cargo update in datafusion-cli directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3075:
URL: https://github.com/apache/arrow-datafusion/pull/3075#issuecomment-1208108605
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3075?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3075](https://codecov.io/gh/apache/arrow-datafusion/pull/3075?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd66933) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/6e6f3bf9dec82b332e21f11699552c34f72493ac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6e6f3bf) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head cd66933 differs from pull request most recent head 4ba1040. Consider uploading reports for the commit 4ba1040 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3075 +/- ##
==========================================
+ Coverage 85.87% 85.88% +0.01%
==========================================
Files 289 289
Lines 51941 51953 +12
==========================================
+ Hits 44604 44620 +16
+ Misses 7337 7333 -4
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/3075?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/core/tests/dataframe\_functions.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3075/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL2RhdGFmcmFtZV9mdW5jdGlvbnMucnM=) | `100.00% <100.00%> (ø)` | |
| [datafusion/expr/src/expr\_fn.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3075/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9leHByX2ZuLnJz) | `90.80% <100.00%> (+0.10%)` | :arrow_up: |
| [...usion/physical-expr/src/aggregate/approx\_median.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3075/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9waHlzaWNhbC1leHByL3NyYy9hZ2dyZWdhdGUvYXBwcm94X21lZGlhbi5ycw==) | `100.00% <100.00%> (+36.36%)` | :arrow_up: |
| [datafusion/physical-expr/src/aggregate/build\_in.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3075/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9waHlzaWNhbC1leHByL3NyYy9hZ2dyZWdhdGUvYnVpbGRfaW4ucnM=) | `89.92% <100.00%> (ø)` | |
| [datafusion/sql/src/planner.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3075/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcWwvc3JjL3BsYW5uZXIucnM=) | `82.00% <100.00%> (-0.02%)` | :arrow_down: |
| [datafusion/core/src/physical\_plan/metrics/value.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3075/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL21ldHJpY3MvdmFsdWUucnM=) | `86.93% <0.00%> (-0.51%)` | :arrow_down: |
| [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3075/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `77.60% <0.00%> (ø)` | |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #3075: [Minor] run cargo update in datafusion-cli directory
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #3075:
URL: https://github.com/apache/arrow-datafusion/pull/3075#issuecomment-1208136617
I filed https://github.com/apache/arrow-datafusion/issues/3077t to discuss adding the cli back to the workspace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #3075: [Minor] run cargo update in datafusion-cli directory
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #3075:
URL: https://github.com/apache/arrow-datafusion/pull/3075#issuecomment-1208100689
I assume this is needed because this project is not part of the workspace? Should we consider making it part of the workspace again? This is what we did recently in the Ballista project, in https://github.com/apache/arrow-ballista/pull/89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3075: [Minor] run cargo update in datafusion-cli directory
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3075:
URL: https://github.com/apache/arrow-datafusion/pull/3075#issuecomment-1208147495
Benchmark runs are scheduled for baseline = 88f65481906a99fba4f5a325756827ba62ff6a2e and contender = c95bb74d0b0cdf28fc96f11a5529b28ad67a7a06. c95bb74d0b0cdf28fc96f11a5529b28ad67a7a06 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0bf6640377e440d58c5022e456bad28c...93393842ab5f4992a73bdc16a3d126be/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f349de945a0246e6b44b7481a76fa68f...802e0002eb154c918e43b45819903cdb/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f3b2a0a1a5c84e31ab60e26959e402c8...fbaf2184b81040f1938207d3c083d57a/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1c3f38fda2264711a6dc6ccf592d588b...bc3ea2c8fbdd4b4abdba7831cc642b0a/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on pull request #3075: [Minor] run cargo update in datafusion-cli directory
Posted by GitBox <gi...@apache.org>.
xudong963 commented on PR #3075:
URL: https://github.com/apache/arrow-datafusion/pull/3075#issuecomment-1208115477
> Should we consider making it part of the workspace again?
Make sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #3075: [Minor] run cargo update in datafusion-cli directory
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #3075:
URL: https://github.com/apache/arrow-datafusion/pull/3075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org