You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/22 07:36:02 UTC
[GitHub] [arrow-datafusion] houqp opened a new pull request #920: add notice file for python binding
houqp opened a new pull request #920:
URL: https://github.com/apache/arrow-datafusion/pull/920
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
From https://github.com/apache/arrow-datafusion/pull/875#discussion_r688900939.
Relates to https://github.com/apache/arrow-datafusion/issues/887.
# Rationale for this change
Since our python binding release artifacts will be binaries, we need to include all licenses used by our dependencies.
# What changes are included in this PR?
Add notice file following https://github.com/apache/arrow/blob/master/NOTICE.txt
# Are there any user-facing changes?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] kszucs commented on pull request #920: add notice file for python binding
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #920:
URL: https://github.com/apache/arrow-datafusion/pull/920#issuecomment-904926151
We maintain the license and notice files manually. I think it's enough to mention the dependencies where we have vendored source code from. Otherwise we'd need to generate the whole cargo dependency tree since we statically link everything with cargo (if I'm not mistaken). cc @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #920: add notice file for python binding
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #920:
URL: https://github.com/apache/arrow-datafusion/pull/920#issuecomment-912276809
closing this in favor of #966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] kou commented on pull request #920: add notice file for python binding
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #920:
URL: https://github.com/apache/arrow-datafusion/pull/920#issuecomment-905073019
These documents will help us:
* http://apache.org/legal/src-headers.html#notice
* https://infra.apache.org/licensing-howto.html#binary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #920: add notice file for python binding
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #920:
URL: https://github.com/apache/arrow-datafusion/pull/920#issuecomment-912272909
Thanks @kszucs and @kou for the pointers. I went through the ASF docs, it looks like we do need to account for the full dependency tree for statically linked binary release :(
For source releases, we only need to take care of vendored source code.
Both LICENSE file and NOTICE needs to be updated for each compiled in dependency for the binary release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jorgecarleitao commented on pull request #920: add notice file for python binding
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #920:
URL: https://github.com/apache/arrow-datafusion/pull/920#issuecomment-903444485
Thanks a lot for taking this, QP!
I was imagining that our notice would have to be something like "go to all our (transitive and non-transitive) dependencies, extract their licenses, create a notice based on the list of dependencies and respective licenses".
This offers the guarantees that anyone using the binary shipped from Apache that we verified that it can be used in the same or comparable terms as the Apache license itself (my understanding of why such notice exists in apache/arrow, but I am not very experienced here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp closed pull request #920: add notice file for python binding
Posted by GitBox <gi...@apache.org>.
houqp closed pull request #920:
URL: https://github.com/apache/arrow-datafusion/pull/920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on pull request #920: add notice file for python binding
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #920:
URL: https://github.com/apache/arrow-datafusion/pull/920#issuecomment-903511774
@kszucs it would be really helpful you can provide some insights here since I noticed you have made significant change to arrow's NOTICE.txt file. Do you know if arrow's NOTICE.txt file is managed manually or through automation? How deep do we need to get into the dependency graph to fish out all the downstream licenses?
The change in this PR only includes non-transitive dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org