You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Robert Scholte (JIRA)" <ji...@codehaus.org> on 2011/12/14 21:19:02 UTC
[jira] (MSHARED-217) Separate inheritance and interpolation
Robert Scholte created MSHARED-217:
--------------------------------------
Summary: Separate inheritance and interpolation
Key: MSHARED-217
URL: https://jira.codehaus.org/browse/MSHARED-217
Project: Maven Shared Components
Issue Type: Improvement
Components: maven-doxia-tools
Affects Versions: maven-doxia-tools-1.4
Reporter: Robert Scholte
The implementation uses recursion to get an inherited model of the site.xml, but every step does the interpolation too.
So if the parent site.xml contains something like ${project.name}, its value will be an ancestor project name, often an unexpected value.
By moving the interpolation from the recursive method to the method-caller you will get the name of the active project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSHARED-217) Separate inheritance and interpolation
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHARED-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte reopened MSHARED-217:
------------------------------------
The IT of MSITE-312 fails due to this modification. It seems that the site.xml should be partially interpolated during recursion.
> Separate inheritance and interpolation
> ---------------------------------------
>
> Key: MSHARED-217
> URL: https://jira.codehaus.org/browse/MSHARED-217
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-doxia-tools
> Affects Versions: maven-doxia-tools-1.4
> Reporter: Robert Scholte
> Assignee: Robert Scholte
> Fix For: maven-doxia-tools-1.5
>
>
> The implementation uses recursion to get an inherited model of the site.xml, but every step does the interpolation too.
> So if the parent site.xml contains something like ${project.name}, its value will be an ancestor project name, often an unexpected value.
> By moving the interpolation from the recursive method to the method-caller you will get the name of the active project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (DOXIATOOLS-34) Separate inheritance and interpolation
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/DOXIATOOLS-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=296004#comment-296004 ]
Robert Scholte commented on DOXIATOOLS-34:
------------------------------------------
Dennis,
I've reverted this change already due to the failing IT. The xml contains three types of data: static, inheritable and extendable. We need find to find a way of smart parsing to define which xml-sections are what kind of data. It's less straightforward as I hoped.
I'd suggest to leave this one open for now and pick it up later.
> Separate inheritance and interpolation
> ---------------------------------------
>
> Key: DOXIATOOLS-34
> URL: https://jira.codehaus.org/browse/DOXIATOOLS-34
> Project: Maven Doxia Tools
> Issue Type: Improvement
> Components: Doxia Integration Tools
> Affects Versions: doxia-integration-tools-1.4
> Reporter: Robert Scholte
> Assignee: Robert Scholte
> Fix For: doxia-integration-tools-1.5
>
>
> The implementation uses recursion to get an inherited model of the site.xml, but every step does the interpolation too.
> So if the parent site.xml contains something like ${project.name}, its value will be an ancestor project name, often an unexpected value.
> By moving the interpolation from the recursive method to the method-caller you will get the name of the active project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (DOXIATOOLS-34) Separate inheritance and interpolation
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/DOXIATOOLS-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=295995#comment-295995 ]
Dennis Lundberg commented on DOXIATOOLS-34:
-------------------------------------------
Robert,
What should we do about this issue?
I'd like to release Site Plugin 3.1 soon. Perhaps we don't need to update Site Plugin to use version 1.5 of doxia-integration-tools yet. In that case we can just leave this issue open a while longer.
> Separate inheritance and interpolation
> ---------------------------------------
>
> Key: DOXIATOOLS-34
> URL: https://jira.codehaus.org/browse/DOXIATOOLS-34
> Project: Maven Doxia Tools
> Issue Type: Improvement
> Components: Doxia Integration Tools
> Affects Versions: doxia-integration-tools-1.4
> Reporter: Robert Scholte
> Assignee: Robert Scholte
> Fix For: doxia-integration-tools-1.5
>
>
> The implementation uses recursion to get an inherited model of the site.xml, but every step does the interpolation too.
> So if the parent site.xml contains something like ${project.name}, its value will be an ancestor project name, often an unexpected value.
> By moving the interpolation from the recursive method to the method-caller you will get the name of the active project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSHARED-217) Separate inheritance and interpolation
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHARED-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte closed MSHARED-217.
----------------------------------
Resolution: Fixed
Fix Version/s: maven-doxia-tools-1.5
Fixed in [rev. 1214470|http://svn.apache.org/viewvc?rev=1214470&view=rev]
> Separate inheritance and interpolation
> ---------------------------------------
>
> Key: MSHARED-217
> URL: https://jira.codehaus.org/browse/MSHARED-217
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-doxia-tools
> Affects Versions: maven-doxia-tools-1.4
> Reporter: Robert Scholte
> Assignee: Robert Scholte
> Fix For: maven-doxia-tools-1.5
>
>
> The implementation uses recursion to get an inherited model of the site.xml, but every step does the interpolation too.
> So if the parent site.xml contains something like ${project.name}, its value will be an ancestor project name, often an unexpected value.
> By moving the interpolation from the recursive method to the method-caller you will get the name of the active project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (DOXIATOOLS-34) Separate inheritance and interpolation
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/DOXIATOOLS-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg updated DOXIATOOLS-34:
--------------------------------------
Fix Version/s: (was: doxia-integration-tools-1.5)
Removing this from the 1.5 release.
> Separate inheritance and interpolation
> ---------------------------------------
>
> Key: DOXIATOOLS-34
> URL: https://jira.codehaus.org/browse/DOXIATOOLS-34
> Project: Maven Doxia Tools
> Issue Type: Improvement
> Components: Doxia Integration Tools
> Affects Versions: doxia-integration-tools-1.4
> Reporter: Robert Scholte
> Assignee: Robert Scholte
>
> The implementation uses recursion to get an inherited model of the site.xml, but every step does the interpolation too.
> So if the parent site.xml contains something like ${project.name}, its value will be an ancestor project name, often an unexpected value.
> By moving the interpolation from the recursive method to the method-caller you will get the name of the active project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (DOXIATOOLS-34) Separate inheritance and interpolation
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/DOXIATOOLS-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg moved MSHARED-217 to DOXIATOOLS-34:
---------------------------------------------------
Fix Version/s: (was: maven-doxia-tools-1.5)
doxia-integration-tools-1.5
Component/s: (was: maven-doxia-tools)
Doxia Integration Tools
Affects Version/s: (was: maven-doxia-tools-1.4)
doxia-integration-tools-1.4
Key: DOXIATOOLS-34 (was: MSHARED-217)
Project: Maven Doxia Tools (was: Maven Shared Components)
> Separate inheritance and interpolation
> ---------------------------------------
>
> Key: DOXIATOOLS-34
> URL: https://jira.codehaus.org/browse/DOXIATOOLS-34
> Project: Maven Doxia Tools
> Issue Type: Improvement
> Components: Doxia Integration Tools
> Affects Versions: doxia-integration-tools-1.4
> Reporter: Robert Scholte
> Assignee: Robert Scholte
> Fix For: doxia-integration-tools-1.5
>
>
> The implementation uses recursion to get an inherited model of the site.xml, but every step does the interpolation too.
> So if the parent site.xml contains something like ${project.name}, its value will be an ancestor project name, often an unexpected value.
> By moving the interpolation from the recursive method to the method-caller you will get the name of the active project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira