You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/11 18:30:00 UTC

[GitHub] holdenk commented on issue #23741: [SPARK-22798][PYTHON][ML]Add multiple column support to PySpark StringIndexer

holdenk commented on issue #23741: [SPARK-22798][PYTHON][ML]Add multiple column support to PySpark StringIndexer
URL: https://github.com/apache/spark/pull/23741#issuecomment-462439933
 
 
   @huaxingao close, but the more I look at the Py4J array code I think my suggestion was not great. I was thinking of using new_array with an array[string] class to construct the outer array, but really it's probably not worth the headache involved so long as we test that the Scala side isn't making assumptions about the arrays being fully populated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org