You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/24 06:00:59 UTC
[GitHub] [spark] huaxingao opened a new pull request, #37643: [SQL][SPARK-39528][FOLLOWUP] Make DynamicPartitionPruningV2FilterSuite extend DynamicPartitionPruningV2Suite
huaxingao opened a new pull request, #37643:
URL: https://github.com/apache/spark/pull/37643
### What changes were proposed in this pull request?
Make `DynamicPartitionPruningV2FilterSuite` extend `DynamicPartitionPruningV2Suite`
### Why are the changes needed?
Make code cleaner
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao closed pull request #37643: [SQL][SPARK-39528][FOLLOWUP] Make DynamicPartitionPruningV2FilterSuite extend DynamicPartitionPruningV2Suite
Posted by GitBox <gi...@apache.org>.
huaxingao closed pull request #37643: [SQL][SPARK-39528][FOLLOWUP] Make DynamicPartitionPruningV2FilterSuite extend DynamicPartitionPruningV2Suite
URL: https://github.com/apache/spark/pull/37643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #37643: [SQL][SPARK-39528][FOLLOWUP] Make DynamicPartitionPruningV2FilterSuite extend DynamicPartitionPruningV2Suite
Posted by GitBox <gi...@apache.org>.
huaxingao commented on PR #37643:
URL: https://github.com/apache/spark/pull/37643#issuecomment-1226082727
Merged to master. Thanks @cloud-fan for your review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a diff in pull request #37643: [SQL][SPARK-39528][FOLLOWUP] Make DynamicPartitionPruningV2FilterSuite extend DynamicPartitionPruningV2Suite
Posted by GitBox <gi...@apache.org>.
huaxingao commented on code in PR #37643:
URL: https://github.com/apache/spark/pull/37643#discussion_r953915403
##########
sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala:
##########
@@ -1807,8 +1807,7 @@ class DynamicPartitionPruningV2SuiteAEOn extends DynamicPartitionPruningV2Suite
with EnableAdaptiveExecutionSuite
abstract class DynamicPartitionPruningV2FilterSuite
- extends DynamicPartitionPruningDataSourceSuiteBase {
- override protected def runAnalyzeColumnCommands: Boolean = false
+ extends DynamicPartitionPruningV2Suite {
override protected def initState(): Unit = {
spark.conf.set("spark.sql.catalog.testcat", classOf[InMemoryTableWithV2FilterCatalog].getName)
Review Comment:
Changed. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37643: [SQL][SPARK-39528][FOLLOWUP] Make DynamicPartitionPruningV2FilterSuite extend DynamicPartitionPruningV2Suite
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37643:
URL: https://github.com/apache/spark/pull/37643#discussion_r953389258
##########
sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala:
##########
@@ -1807,8 +1807,7 @@ class DynamicPartitionPruningV2SuiteAEOn extends DynamicPartitionPruningV2Suite
with EnableAdaptiveExecutionSuite
abstract class DynamicPartitionPruningV2FilterSuite
- extends DynamicPartitionPruningDataSourceSuiteBase {
- override protected def runAnalyzeColumnCommands: Boolean = false
+ extends DynamicPartitionPruningV2Suite {
override protected def initState(): Unit = {
spark.conf.set("spark.sql.catalog.testcat", classOf[InMemoryTableWithV2FilterCatalog].getName)
Review Comment:
shall we call `super.initState` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org