[jira] [Commented] (FLINK-8425) SpilledSubpartitionView not protected against concurrent release calls

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331165#comment-16331165 ] 

ASF GitHub Bot commented on FLINK-8425:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/5314

    [FLINK-8425][network] fix SpilledSubpartitionView not protected against concurrent release calls

    ## What is the purpose of the change
    
    It seems like `SpilledSubpartitionView` is not protected against concurrently calling `releaseAllResources()` as the other `ResultSubpartitionView` implementations. These may happen due to failures, e.g. network channels breaking, and will probably only result in some unexpected exceptions being thrown, e.g. from reading from a closed file reader.
    
    Please note that this PR is based on #4552 which also touches this code area.
    
    ## Brief change log
    
    - apply simple synchronization in `SpilledSubpartitionView`
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no** (per buffer, but in spilled cases)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **not applicable**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-8425

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5314.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5314
    
----
commit c6b1f913b01db5acdd1364063b3998ccecb8317d
Author: Zhijiang <wa...@...>
Date:   2017-09-30T06:36:19Z

    [FLINK-7456][network] Implement Netty sender incoming pipeline for credit-based

commit 7dd59f25a11b98e896c8a514f409e8ebb3127529
Author: Zhijiang <wa...@...>
Date:   2018-01-18T15:30:34Z

    [FLINK-7456][fixup] Add the related parameters in the document

commit 62e16f0f0a52b8f831f4438c6ed99b8aa72c0145
Author: Nico Kruber <ni...@...>
Date:   2018-01-18T19:54:14Z

    [FLINK-7456][network] revert integrating initialCredit into unannouncedCredit
    
    A PartitionRequest could actually be sent multiple times and each time it must
    contain the same credit (only one of those messages will actually be used).

commit 7bdcae31953339c75927b6c1292d164da52915f1
Author: Zhijiang <wa...@...>
Date:   2018-01-17T06:15:04Z

    [hotfix] Add the switch for keeping both the old mode and the new credit-based mode

commit 2bd12a1d3c6cf51778dec0b043fa8b06fcaf06d8
Author: Nico Kruber <ni...@...>
Date:   2018-01-18T16:24:59Z

    fixup! [hotfix] Add the switch for keeping both the old mode and the new credit-based mode

commit 321221d6b00d72100088a64c57b121e9571d5dc7
Author: Nico Kruber <ni...@...>
Date:   2018-01-18T20:27:46Z

    [FLINK-8425][network] fix SpilledSubpartitionView not protected against concurrent release calls

----


> SpilledSubpartitionView not protected against concurrent release calls
> ----------------------------------------------------------------------
>
>                 Key: FLINK-8425
>                 URL: https://issues.apache.org/jira/browse/FLINK-8425
>             Project: Flink
>          Issue Type: Bug
>          Components: Network
>    Affects Versions: 1.1.0, 1.0.1, 1.0.2, 1.0.3, 1.2.0, 1.1.1, 1.1.2, 1.1.3, 1.1.4, 1.3.0, 1.2.1, 1.3.1, 1.4.0, 1.3.2
>            Reporter: Nico Kruber
>            Priority: Minor
>
> It seems like {{SpilledSubpartitionView}} is not protected against concurrently calling {{releaseAllResources}} as the other {{ResultSubpartitionView}} implementations. These may happen due to failures, e.g. network channels breaking, and will probably only result in some unexpected exceptions being thrown, e.g. from reading from a closed file reader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)