You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by apsaltis <gi...@git.apache.org> on 2017/01/19 19:41:18 UTC
[GitHub] nifi pull request #1433: NIFI-2615 Adding support for GetTCP processor
GitHub user apsaltis opened a pull request:
https://github.com/apache/nifi/pull/1433
NIFI-2615 Adding support for GetTCP processor
This is a major refactoring of a previous version of this processor that was never merged due to poor design. Special thanks to @olegz for all of his help in refactoring this processor to bring it inline with NiFi best practices.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apsaltis/nifi NIFI-2615
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1433.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1433
----
commit d53fa786bcc62a82f38ae87e0147863acaee9ce1
Author: Andrew Psaltis <ps...@gmail.com>
Date: 2017-01-19T19:36:50Z
NIFI-2615 Adding GetTCP Processor
This is a major refactoring of the previous version of this processor.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1433: NIFI-2615 Adding support for GetTCP processor
Posted by apsaltis <gi...@git.apache.org>.
Github user apsaltis closed the pull request at:
https://github.com/apache/nifi/pull/1433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1433: NIFI-2615 Adding support for GetTCP processor
Posted by apsaltis <gi...@git.apache.org>.
Github user apsaltis commented on the issue:
https://github.com/apache/nifi/pull/1433
@mosermw Changing the name certainly makes sense to me. Honestly had not dawned on my that it was the first processor whose name matches the nar.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1433: NIFI-2615 Adding support for GetTCP processor
Posted by mosermw <gi...@git.apache.org>.
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1433
Nice contribution, @apsaltis. Does this need to be in its own nifi-gettcp-bundle? PutTCP is in the nifi-standard-bundle and I would expect GetTCP and PutTCP to be located in the same NAR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1433: NIFI-2615 Adding support for GetTCP processor
Posted by mosermw <gi...@git.apache.org>.
Github user mosermw commented on the issue:
https://github.com/apache/nifi/pull/1433
That's definitely a fair reason. I believe this would be the first NAR whose name contains the name of a processor. Would you consider changing the name to nifi-tcp-bundle and nifi-tcp-nar? When the extension registry is ready, then we could move PutTCP into this nar?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1433: NIFI-2615 Adding support for GetTCP processor
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the issue:
https://github.com/apache/nifi/pull/1433
@mosermw +1 to the name change!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1433: NIFI-2615 Adding support for GetTCP processor
Posted by apsaltis <gi...@git.apache.org>.
Github user apsaltis commented on the issue:
https://github.com/apache/nifi/pull/1433
@mosermw -- I can totally see how this processor would be at home in the same NAR, the reasoning for keeping it separate was to have one less processor to modify and hopefully ease the effort to integrate it into the extension registry [1] when that is ready.
[1] https://cwiki.apache.org/confluence/display/NIFI/Extension+Repositories+%28aka+Extension+Registry%29+for+Dynamically-loaded+Extensions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---