You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yanghua <gi...@git.apache.org> on 2018/06/05 14:41:31 UTC
[GitHub] flink pull request #6123: [FLINK-9521] Add shade plugin executions to packag...
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6123
[FLINK-9521] Add shade plugin executions to package table example jar
## What is the purpose of the change
*This pull request add shade plugin executions to package table example jar*
## Brief change log
- *Add shade plugin executions to package table example jar*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-9521
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6123.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6123
----
commit 3fd4a0029ed89205eed21153582bae3dc2e01cc0
Author: yanghua <ya...@...>
Date: 2018-06-05T14:38:14Z
[FLINK-9521] Add shade plugin executions to package table example jar
----
---
[GitHub] flink pull request #6123: [FLINK-9521] Add shade plugin executions to packag...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/6123
---
[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6123
@twalthr can you have a look?
---
[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6123
cc @fhueske can you review this PR?
---
[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6123
Please provide a reasoning when opening JIRAs, i.e. the answer to "Why should we make this change?".
---
[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6123
cc @dawidwys can you review this?
---
[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6123
hi @tillrohrmann I think we should include the table example jar into Flink's binary distribution just like `batch`, `streaming`, `gelly`, `python` examples for those people who do not want to try SQL Client. It can make the `examples` dir keeps completeness. Maybe it's an omission before.
---
[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/6123
I'm with Till here. The example JARs add very little value. I would be OK with adding them if this was lightweight, but each example will include the Table API and its dependencies (incl. Calcite and Janino) and hence be 16MB in size.
So adding these examples to the distribution adds 80MB in total for very little value.
Hence, I would not add them to the distribution.
---
[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6123
OK, yes, this PR really make the binary package size more bigger. Closing this issue...
---
[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6123
Thanks for opening the PR @yanghua. I would need some input from @twalthr or @fhueske whether it already makes sense to include the Flink table example programs in Flink's binary distribution.
I'm not entirely sure whether adding table API example programs would add much additional value since in the end it is just another jar which you can submit. I think the sql cli with which you can run SQL statements would serve this purpose better.
---
[GitHub] flink issue #6123: [FLINK-9521] Add shade plugin executions to package table...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/6123
cc @twalthr
---