You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/28 02:45:45 UTC

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #177: [FLINK-28264] Refactor split and read in table store

LadyForest commented on code in PR #177:
URL: https://github.com/apache/flink-table-store/pull/177#discussion_r907977310


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreRead.java:
##########
@@ -33,6 +31,5 @@
 public interface FileStoreRead<T> {
 
     /** Create a {@link RecordReader} from partition and bucket and files. */

Review Comment:
   Nit: modify the comment since the input argument has changed.
   ```suggestion
       /** Create a {@link RecordReader} from split. */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org