You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mridulm <gi...@git.apache.org> on 2017/04/11 19:19:13 UTC
[GitHub] spark issue #17610: [SPARK-20131][Core]Use a separate lock for StandaloneSch...
Github user mridulm commented on the issue:
https://github.com/apache/spark/pull/17610
Isn't it not depending on 'this' being locked in super class method ?
If it is not, then why not simply restrict lock to changing of `stopping` flag (if already set, return, else set and proceed down method) ? In which case, use of `this` will do without need for a new lock ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org