You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2009/03/09 17:20:50 UTC
[jira] Created: (SLING-881) Improve property handling
Improve property handling
-------------------------
Key: SLING-881
URL: https://issues.apache.org/jira/browse/SLING-881
Project: Sling
Issue Type: Improvement
Components: Servlets Post
Affects Versions: Servlets Post 2.0.2
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
Fix For: Servlets Post 2.0.4
I've two improvements for the Sling Post Servlet:
- if a property is updated and no type hint is sent from the client, the property is set as a string which usually changes the property type if it wasn't a string before. It would be better to first check if the property already exists and if no type hint is sent, use the current type of the property to update the value.
- If a property is tried to be removed (no values are sent), always a delete change is added. The change should only be recorded if the property has really been removed.
I've added a patch which I intend to apply in the next days if noone objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-881) Improve property handling
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed SLING-881.
----------------------------------
Resolution: Fixed
Applied the patch in Revision: 752208
> Improve property handling
> -------------------------
>
> Key: SLING-881
> URL: https://issues.apache.org/jira/browse/SLING-881
> Project: Sling
> Issue Type: Improvement
> Components: Servlets Post
> Affects Versions: Servlets Post 2.0.2
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: Servlets Post 2.0.4
>
> Attachments: SlingPropertyValueHandler.java.patch
>
>
> I've two improvements for the Sling Post Servlet:
> - if a property is updated and no type hint is sent from the client, the property is set as a string which usually changes the property type if it wasn't a string before. It would be better to first check if the property already exists and if no type hint is sent, use the current type of the property to update the value.
> - If a property is tried to be removed (no values are sent), always a delete change is added. The change should only be recorded if the property has really been removed.
> I've added a patch which I intend to apply in the next days if noone objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-881) Improve property handling
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler updated SLING-881:
-----------------------------------
Attachment: SlingPropertyValueHandler.java.patch
Suggested patch
> Improve property handling
> -------------------------
>
> Key: SLING-881
> URL: https://issues.apache.org/jira/browse/SLING-881
> Project: Sling
> Issue Type: Improvement
> Components: Servlets Post
> Affects Versions: Servlets Post 2.0.2
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: Servlets Post 2.0.4
>
> Attachments: SlingPropertyValueHandler.java.patch
>
>
> I've two improvements for the Sling Post Servlet:
> - if a property is updated and no type hint is sent from the client, the property is set as a string which usually changes the property type if it wasn't a string before. It would be better to first check if the property already exists and if no type hint is sent, use the current type of the property to update the value.
> - If a property is tried to be removed (no values are sent), always a delete change is added. The change should only be recorded if the property has really been removed.
> I've added a patch which I intend to apply in the next days if noone objects.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.