You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/04/11 04:35:44 UTC
Review Request 58328: Updated tests to set '--executor_secret_key' as
a path.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58328/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Updated tests to set '--executor_secret_key' as a path.
Diffs
-----
src/tests/mesos.cpp 099ec376878faaa7efe5bc030785db717cb16f59
Diff: https://reviews.apache.org/r/58328/diff/1/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 58328: Updated tests to set
'--executor_secret_key' as a path.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58328/#review171953
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 13, 2017, 8:17 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58328/
> -----------------------------------------------------------
>
> (Updated April 13, 2017, 8:17 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-6999
> https://issues.apache.org/jira/browse/MESOS-6999
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the test code to generate a secret key file
> and set the agent '--executor_secret_key' flag with its path.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp fe897c184829910addec95ace174546092a9e2b2
> src/tests/mesos.cpp 099ec376878faaa7efe5bc030785db717cb16f59
>
>
> Diff: https://reviews.apache.org/r/58328/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 58328: Updated tests to set
'--executor_secret_key' as a path.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58328/
-----------------------------------------------------------
(Updated April 13, 2017, 8:17 p.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Bugs: MESOS-6999
https://issues.apache.org/jira/browse/MESOS-6999
Repository: mesos
Description
-------
This patch updates the test code to generate a secret key file
and set the agent '--executor_secret_key' flag with its path.
Diffs (updated)
-----
src/tests/mesos.hpp fe897c184829910addec95ace174546092a9e2b2
src/tests/mesos.cpp 099ec376878faaa7efe5bc030785db717cb16f59
Diff: https://reviews.apache.org/r/58328/diff/2/
Changes: https://reviews.apache.org/r/58328/diff/1-2/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 58328: Updated tests to set
'--executor_secret_key' as a path.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 13, 2017, 6:54 p.m., Greg Mann wrote:
> > src/tests/mesos.cpp
> > Lines 218-235 (patched)
> > <https://reviews.apache.org/r/58328/diff/1/?file=1687742#file1687742line218>
> >
> > Use `os::write()`
Looks like we don't provide an overload of `os::write` which accepts access permission bits.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58328/#review171915
-----------------------------------------------------------
On April 11, 2017, 4:37 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58328/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 4:37 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-6999
> https://issues.apache.org/jira/browse/MESOS-6999
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the test code to generate a secret key file
> and set the agent '--executor_secret_key' flag with its path.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp 099ec376878faaa7efe5bc030785db717cb16f59
>
>
> Diff: https://reviews.apache.org/r/58328/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 58328: Updated tests to set
'--executor_secret_key' as a path.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58328/#review171915
-----------------------------------------------------------
src/tests/mesos.cpp
Lines 218-235 (patched)
<https://reviews.apache.org/r/58328/#comment244910>
Use `os::write()`
- Greg Mann
On April 11, 2017, 4:37 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58328/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 4:37 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-6999
> https://issues.apache.org/jira/browse/MESOS-6999
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the test code to generate a secret key file
> and set the agent '--executor_secret_key' flag with its path.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp 099ec376878faaa7efe5bc030785db717cb16f59
>
>
> Diff: https://reviews.apache.org/r/58328/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 58328: Updated tests to set
'--executor_secret_key' as a path.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58328/#review171561
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58327, 58328]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 11, 2017, 4:37 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58328/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 4:37 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-6999
> https://issues.apache.org/jira/browse/MESOS-6999
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the test code to generate a secret key file
> and set the agent '--executor_secret_key' flag with its path.
>
>
> Diffs
> -----
>
> src/tests/mesos.cpp 099ec376878faaa7efe5bc030785db717cb16f59
>
>
> Diff: https://reviews.apache.org/r/58328/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 58328: Updated tests to set
'--executor_secret_key' as a path.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58328/
-----------------------------------------------------------
(Updated April 11, 2017, 4:37 a.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Bugs: MESOS-6999
https://issues.apache.org/jira/browse/MESOS-6999
Repository: mesos
Description (updated)
-------
This patch updates the test code to generate a secret key file
and set the agent '--executor_secret_key' flag with its path.
Diffs
-----
src/tests/mesos.cpp 099ec376878faaa7efe5bc030785db717cb16f59
Diff: https://reviews.apache.org/r/58328/diff/1/
Testing
-------
`make check`
Thanks,
Greg Mann