[GitHub] [couchdb] nickva commented on a diff in pull request #4179: Don't double-encode changes sequence strings in the replicator

[GitBox <gi...@apache.org>]

nickva commented on code in PR #4179:
URL: https://github.com/apache/couchdb/pull/4179#discussion_r973623252


##########
src/couch_replicator/src/couch_replicator_api_wrap.erl:
##########
@@ -148,7 +148,8 @@ get_pending_count(#httpdb{} = Db, Seq) when is_number(Seq) ->
         end
     end);
 get_pending_count(#httpdb{} = Db, Seq) ->
-    Options = [{path, "_changes"}, {qs, [{"since", ?JSON_ENCODE(Seq)}, {"limit", "0"}]}],
+    Seq1 = couch_replicator_utils:seq_encode(Seq),

Review Comment:
   Good idea



##########
src/couch_replicator/src/couch_replicator_api_wrap.erl:
##########
@@ -539,6 +540,7 @@ changes_since(
     Options
 ) ->
     Timeout = erlang:max(1000, InactiveTimeout div 3),
+    Seq = couch_replicator_utils:seq_encode(StartSeq),

Review Comment:
   Agree, that would be clearer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org