You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/23 17:46:16 UTC

[jira] [Commented] (NIFI-2098) Improve testManyFilesOpened in TestStandardProcessSession

    [ https://issues.apache.org/jira/browse/NIFI-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346849#comment-15346849 ] 

ASF GitHub Bot commented on NIFI-2098:
--------------------------------------

GitHub user JPercivall opened a pull request:

    https://github.com/apache/nifi/pull/570

    NIFI-2098 Adding ignore annotation to testManyFilesOpened unit test

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JPercivall/nifi NIFI-2098

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/570.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #570
    
----
commit f029ac28e8cd8d84d2390f8dbb0b8c01a2e6a37b
Author: jpercivall <jo...@yahoo.com>
Date:   2016-06-23T17:45:21Z

    NIFI-2098 Adding ignore annotation to testManyFilesOpened unit test

----


> Improve testManyFilesOpened in TestStandardProcessSession
> ---------------------------------------------------------
>
>                 Key: NIFI-2098
>                 URL: https://issues.apache.org/jira/browse/NIFI-2098
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Joseph Percivall
>            Priority: Minor
>
> This unit test[1] is just unnecessarily long and poorly written (uses System.out). What the test is trying to test should be revisited and at the very least it should be ignored for the maven build. 
> [1] https://github.com/apache/nifi/blob/0.x/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/repository/TestStandardProcessSession.java#L804-L804



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)