[GitHub] metron pull request #1079: Fix dash score so that it always shows a value if...

[sardell <gi...@git.apache.org>]

GitHub user sardell opened a pull request:

    https://github.com/apache/metron/pull/1079

    Fix dash score so that it always shows a value if a group-by is selected

    ## Contributor Comments
    [As described in this issue](https://issues.apache.org/jira/browse/METRON-1631), the dash score in the tree view wouldn't have a value if only one Group By button was selected. This was caused by logic in the tree view executing before the required data was returned by the global configuration service. For a quick and simple solution, I removed the service subscription and instead chose to pass the global configuration as an `@Input` since the parent component is already fetching that data with its own service subscription on app load. I also removed `getGroupRequest()` from the tree view selector 's `*ngIf` logic because the parent component already fetches that information too.
    
    While doing this work, I noticed that there are several repetitive subscriptions for data. In the future, we may want to switch to injecting these services in the app module or using a store solution like ngrx so they can be singletons.
    
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sardell/metron METRON-1631

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1079.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1079
    
----
commit 7346a0f3f06376e2288d4109add95fb4ecca2356
Author: Shane Ardell <sa...@...>
Date:   2018-06-26T12:01:34Z

    pass globalConfig and remove unnecessary function call

----


---

[GitHub] metron pull request #1079: Fix dash score so that it always shows a value if...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/metron/pull/1079


---

[GitHub] metron issue #1079: Fix dash score so that it always shows a value if a grou...

[merrimanr <gi...@git.apache.org>]

Github user merrimanr commented on the issue:

    https://github.com/apache/metron/pull/1079
  
    I tested this in full dev and group requests are correctly being sent with the score field when 1 group is selected.  +1


---