You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/05 10:24:27 UTC

[GitHub] [airflow] nullhack edited a comment on pull request #9464: Fix DockerOperator xcom

nullhack edited a comment on pull request #9464:
URL: https://github.com/apache/airflow/pull/9464#issuecomment-703541914


   Thank you, yes you're right. They're failing because the test assume a binary string `b'container log'`
   
   One of the modifications of this PR was changing this to a decoded string instead (to have same output as bash operator and make It easier to use the xcom results from other operators).
   
   At this point I have three options
   
   1. Change the behavior of the tests to the new one (can introduce breaking changes, as the current behavior is binary)
   2. Introduce a new flag argument for the operator with default binary, but modifiable to include the new behavior
   3. Remove the new behavior
   
   Which one  should I go for?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org