You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "yamt (via GitHub)" <gi...@apache.org> on 2023/03/08 22:18:31 UTC
[GitHub] [nuttx] yamt opened a new pull request, #8772: Add sim:toywasm config
yamt opened a new pull request, #8772:
URL: https://github.com/apache/nuttx/pull/8772
## Summary
Add sim:toywasm config
## Impact
## Testing
Tested on macOS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8772: Add sim:toywasm config
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8772:
URL: https://github.com/apache/nuttx/pull/8772#issuecomment-1518152788
@yamt please resolve the conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #8772: Add sim:toywasm config
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #8772:
URL: https://github.com/apache/nuttx/pull/8772#discussion_r1130144610
##########
boards/sim/sim/sim/README.txt:
##########
@@ -1245,6 +1245,18 @@ touchscreen
See apps/examples/README.txt for further information about build
requirements and configuration settings.
+toywasm
+
+ This is a configuration with toywasm.
+
+ An example usage:
+
+ NuttShell (NSH) NuttX-10.4.0
+ nsh> mount -t hostfs -o fs=/tmp/wasm /mnt
+ nsh> toywasm --wasi /mnt/hello.wasm
+ hello
+ nsh>
+
Review Comment:
Please move to Documentation/
We are trying to phase out all boards README.txt and keep everything in the web site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] yamt commented on pull request #8772: Add sim:toywasm config
Posted by "yamt (via GitHub)" <gi...@apache.org>.
yamt commented on PR #8772:
URL: https://github.com/apache/nuttx/pull/8772#issuecomment-1519040718
> @yamt please resolve the conflict.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8772: Add sim:toywasm config
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #8772:
URL: https://github.com/apache/nuttx/pull/8772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] yamt commented on a diff in pull request #8772: Add sim:toywasm config
Posted by "yamt (via GitHub)" <gi...@apache.org>.
yamt commented on code in PR #8772:
URL: https://github.com/apache/nuttx/pull/8772#discussion_r1130166967
##########
boards/sim/sim/sim/README.txt:
##########
@@ -1245,6 +1245,18 @@ touchscreen
See apps/examples/README.txt for further information about build
requirements and configuration settings.
+toywasm
+
+ This is a configuration with toywasm.
+
+ An example usage:
+
+ NuttShell (NSH) NuttX-10.4.0
+ nsh> mount -t hostfs -o fs=/tmp/wasm /mnt
+ nsh> toywasm --wasi /mnt/hello.wasm
+ hello
+ nsh>
+
Review Comment:
do you mean to block this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] yamt commented on a diff in pull request #8772: Add sim:toywasm config
Posted by "yamt (via GitHub)" <gi...@apache.org>.
yamt commented on code in PR #8772:
URL: https://github.com/apache/nuttx/pull/8772#discussion_r1131003534
##########
boards/sim/sim/sim/README.txt:
##########
@@ -1245,6 +1245,18 @@ touchscreen
See apps/examples/README.txt for further information about build
requirements and configuration settings.
+toywasm
+
+ This is a configuration with toywasm.
+
+ An example usage:
+
+ NuttShell (NSH) NuttX-10.4.0
+ nsh> mount -t hostfs -o fs=/tmp/wasm /mnt
+ nsh> toywasm --wasi /mnt/hello.wasm
+ hello
+ nsh>
+
Review Comment:
https://github.com/apache/nuttx/pull/8777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org