You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zuotingbing <gi...@git.apache.org> on 2017/08/24 06:51:34 UTC
[GitHub] spark pull request #19034: [SPARK-21821][CORE]Support to force kill the Coar...
GitHub user zuotingbing opened a pull request:
https://github.com/apache/spark/pull/19034
[SPARK-21821][CORE]Support to force kill the CoarseGrainedExecutorBackend process which is likely be orphaned.
## What changes were proposed in this pull request?
In out production environments, it often happens that even the application has finished, but the CoarseGrainedExecutorBackend process still exists and take up the resource.
Take a look at ExecutorRunner.scala, it maybe failed to terminate process in killProcess method for some reason. In this case, the process of CoarseGrainedExecutorBackend will likely be orphaned. It would be great to support a script to kill the CoarseGrainedExecutorBackend process forcibly.
## How was this patch tested?
manual tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zuotingbing/spark SPARK-21821
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19034.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19034
----
commit 00955e5a86db5acf4d7ff05135e135a807273b70
Author: zuotingbing <zu...@zte.com.cn>
Date: 2017-08-24T06:47:10Z
[SPARK-21821][CORE]Support to force kill the CoarseGrainedExecutorBackend process which is likely be orphaned.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19034: [SPARK-21821][CORE]Support to force kill the CoarseGrain...
Posted by zuotingbing <gi...@git.apache.org>.
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/19034
Hmm, this problem is common , i think some helpful tool scripts is to be expected to make spark more robust, and are useful for users. ：）
Similarly In Hive, there is a tool script ClearDanglingScratchDir.sh, which help to clean dangling scratch directory left behind in some cases, such as when vm restarts and leave no chance for Hive to run shutdown hook.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19034: [SPARK-21821][CORE]Support to force kill the CoarseGrain...
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19034
Agree with @vanzin , if you really want to fix this issue I think you should find out the root cause and fix the code in Spark.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19034: [SPARK-21821][CORE]Support to force kill the CoarseGrain...
Posted by zuotingbing <gi...@git.apache.org>.
Github user zuotingbing commented on the issue:
https://github.com/apache/spark/pull/19034
@srowen @vanzin could you please take a look at this? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19034: [SPARK-21821][CORE]Support to force kill the CoarseGrain...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19034
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19034: [SPARK-21821][CORE]Support to force kill the CoarseGrain...
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19034
My thinking is that different users may have different deploys and different environment, so usually they will maintain their own scripts for such purpose, this seems not a Spark problem from my understanding.
Maybe @srowen can weigh in this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19034: [SPARK-21821][CORE]Support to force kill the CoarseGrain...
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19034
Should it be better to maintain it in your in-house env rather than in community Spark? IMHO such script seem not so proper to maintain Spark codebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19034: [SPARK-21821][CORE]Support to force kill the CoarseGrain...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19034
A script to kill things like this is the wrong way to fix the problem you're reporting. If the app is finished the cluster manager should be making sure the executors are going away.
If it's useful to you for now, great, but I don't think it belongs in Spark.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19034: [SPARK-21821][CORE]Support to force kill the Coar...
Posted by zuotingbing <gi...@git.apache.org>.
Github user zuotingbing closed the pull request at:
https://github.com/apache/spark/pull/19034
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org