You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2014/12/10 01:59:39 UTC

svn commit: r1644272 - in /lucene/dev/trunk/lucene: core/src/java/org/apache/lucene/codecs/lucene50/Lucene50StoredFieldsFormat.java test-framework/src/java/org/apache/lucene/codecs/compressing/HighCompressionCompressingCodec.java

Author: rmuir
Date: Wed Dec 10 00:59:39 2014
New Revision: 1644272

URL: http://svn.apache.org/r1644272
Log:
LUCENE-6100: further tuning of BEST_COMPRESSION

Modified:
    lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/lucene50/Lucene50StoredFieldsFormat.java
    lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/codecs/compressing/HighCompressionCompressingCodec.java

Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/lucene50/Lucene50StoredFieldsFormat.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/lucene50/Lucene50StoredFieldsFormat.java?rev=1644272&r1=1644271&r2=1644272&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/lucene50/Lucene50StoredFieldsFormat.java (original)
+++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/codecs/lucene50/Lucene50StoredFieldsFormat.java Wed Dec 10 00:59:39 2014
@@ -48,7 +48,7 @@ import org.apache.lucene.util.packed.Pac
  * compression ratio, it should provide interesting compression ratios
  * for redundant inputs (such as log files, HTML or plain text). For higher
  * compression, you can choose ({@link Mode#BEST_COMPRESSION BEST_COMPRESSION}), which uses 
- * the <a href="http://en.wikipedia.org/wiki/DEFLATE">DEFLATE</a> algorithm with 24KB blocks 
+ * the <a href="http://en.wikipedia.org/wiki/DEFLATE">DEFLATE</a> algorithm with 60KB blocks 
  * for a better ratio at the expense of slower performance. 
  * These two options can be configured like this: </p>
  * <pre class="prettyprint">
@@ -184,7 +184,7 @@ public final class Lucene50StoredFieldsF
       case BEST_SPEED: 
         return new CompressingStoredFieldsFormat("Lucene50StoredFieldsFast", CompressionMode.FAST, 1 << 14, 128);
       case BEST_COMPRESSION: 
-        return new CompressingStoredFieldsFormat("Lucene50StoredFieldsHigh", CompressionMode.HIGH_COMPRESSION, 24576, 512);
+        return new CompressingStoredFieldsFormat("Lucene50StoredFieldsHigh", CompressionMode.HIGH_COMPRESSION, 61440, 512);
       default: throw new AssertionError();
     }
   }

Modified: lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/codecs/compressing/HighCompressionCompressingCodec.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/codecs/compressing/HighCompressionCompressingCodec.java?rev=1644272&r1=1644271&r2=1644272&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/codecs/compressing/HighCompressionCompressingCodec.java (original)
+++ lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/codecs/compressing/HighCompressionCompressingCodec.java Wed Dec 10 00:59:39 2014
@@ -29,8 +29,8 @@ public class HighCompressionCompressingC
 
   /** Default constructor. */
   public HighCompressionCompressingCodec() {
-    // no need to have a higher block length than 32KB since deflate splits
-    // into blocks of 32KB anyway, and this is a lower bound (try to avoid > 32KB)
-    this(24576, 512, false);
+    // we don't worry about zlib block overhead as its
+    // not bad and try to save space instead:
+    this(61440, 512, false);
   }
 }