You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/02/25 13:36:50 UTC
[GitHub] [fineract-cn-mobile] prajwal27 opened a new pull request #72: fix:
Improve search feature in Customer Fragment
prajwal27 opened a new pull request #72: fix: Improve search feature in Customer Fragment
URL: https://github.com/apache/fineract-cn-mobile/pull/72
**Summary**
The Search functionality in CustomersFragment opearted on clicking of submit button. Now, the Search functionality works simultaneouly with change of text in search bar.
Also, the search was not displaying any message when "offline" was choosen. Now, it shows a message in snackbar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract-cn-mobile] prajwal27 closed pull request #72: fix:
Improve search feature in Customer Fragment
Posted by GitBox <gi...@apache.org>.
prajwal27 closed pull request #72: fix: Improve search feature in Customer Fragment
URL: https://github.com/apache/fineract-cn-mobile/pull/72
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract-cn-mobile] jawidMuhammadi commented on a change in pull
request #72: fix: Improve search feature in Customer Fragment
Posted by GitBox <gi...@apache.org>.
jawidMuhammadi commented on a change in pull request #72: fix: Improve search feature in Customer Fragment
URL: https://github.com/apache/fineract-cn-mobile/pull/72#discussion_r384369158
##########
File path: app/src/main/java/org/apache/fineract/ui/online/customers/customerlist/CustomersFragment.java
##########
@@ -271,14 +271,15 @@ private void setUpSearchInterface(Menu menu) {
searchView.setOnQueryTextListener(new SearchView.OnQueryTextListener() {
@Override
public boolean onQueryTextSubmit(String query) {
- findCustomer(query);
return false;
}
@Override
public boolean onQueryTextChange(String newText) {
if (TextUtils.isEmpty(newText)) {
customerAdapter.setCustomers(customers);
+ } else {
+ findCustomer(newText);
Review comment:
Here you have check style violation. You have added 1 more space on line number 283.
How to solve it?
Go to your CustomersFragment.java file enter `Ctr+Alt+SPACE`. It will solve the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract-cn-mobile] prajwal27 commented on issue #72: fix: Improve
search feature in Customer Fragment
Posted by GitBox <gi...@apache.org>.
prajwal27 commented on issue #72: fix: Improve search feature in Customer Fragment
URL: https://github.com/apache/fineract-cn-mobile/pull/72#issuecomment-591641008
> Whenever you are solving an issue or making ay enhancement, make different braches for each from the development branch and don't make any changes to it.
Yeah. Will keep in mind for the next PR's.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract-cn-mobile] prajwal27 edited a comment on issue #72: fix:
Improve search feature in Customer Fragment
Posted by GitBox <gi...@apache.org>.
prajwal27 edited a comment on issue #72: fix: Improve search feature in Customer Fragment
URL: https://github.com/apache/fineract-cn-mobile/pull/72#issuecomment-590880138
@therajanmaurya " ./gradlew check " is giving failure for the forked repository.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract-cn-mobile] jawidMuhammadi commented on issue #72: fix:
Improve search feature in Customer Fragment
Posted by GitBox <gi...@apache.org>.
jawidMuhammadi commented on issue #72: fix: Improve search feature in Customer Fragment
URL: https://github.com/apache/fineract-cn-mobile/pull/72#issuecomment-591329560
Whenever you are solving an issue or making ay enhancement, make different braches for each from the development branch and don't make any changes to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract-cn-mobile] prajwal27 commented on issue #72: fix: Improve
search feature in Customer Fragment
Posted by GitBox <gi...@apache.org>.
prajwal27 commented on issue #72: fix: Improve search feature in Customer Fragment
URL: https://github.com/apache/fineract-cn-mobile/pull/72#issuecomment-590880138
@therajanmaurya " ./gradlew check " is giving failure for the forked repository.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services