You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by prasanthj <gi...@git.apache.org> on 2018/06/04 06:27:33 UTC

[GitHub] orc pull request #279: ORC-373: Option to disable dictionary encoding

GitHub user prasanthj opened a pull request:

    https://github.com/apache/orc/pull/279

    ORC-373: Option to disable dictionary encoding

    disables dictionary encoding at the time of string tree writer initialization.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prasanthj/orc ORC-373

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #279
    
----
commit a2a091b23972523b2c55448808dbb695f19ee4ef
Author: Prasanth Jayachandran <pr...@...>
Date:   2018-06-02T02:24:22Z

    ORC-373: Option to disable dictionary encoding

commit 7b8f90223b3d1021eff17b52ce92417ed561548c
Author: Prasanth Jayachandran <pr...@...>
Date:   2018-06-04T06:22:38Z

    Added unit test

----


---

[GitHub] orc pull request #279: ORC-373: Option to disable dictionary encoding

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/orc/pull/279


---

[GitHub] orc issue #279: ORC-373: Option to disable dictionary encoding

Posted by omalley <gi...@git.apache.org>.

Github user omalley commented on the issue:

    https://github.com/apache/orc/pull/279
  
    Prasanth, rather than adding the flush count, which is really test code in the main source, how about creating a StringTreeWriter and catching the stream directly. I'd propose this - https://github.com/omalley/orc/blob/8a782d204f071e2bd16bcfd591a54319fadff132/java/core/src/test/org/apache/orc/TestStringDictionary.java#L251


---

[GitHub] orc issue #279: ORC-373: Option to disable dictionary encoding

Posted by prasanthj <gi...@git.apache.org>.

Github user prasanthj commented on the issue:

    https://github.com/apache/orc/pull/279
  
    lgtm


---