You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/09 03:30:06 UTC

[GitHub] [pulsar] gaoran10 commented on a change in pull request #14604: add chunk message id

gaoran10 commented on a change in pull request #14604:
URL: https://github.com/apache/pulsar/pull/14604#discussion_r822248255



##########
File path: pulsar-client-cpp/include/pulsar/MessageId.h
##########
@@ -55,7 +60,12 @@ class PULSAR_PUBLIC MessageId {
     static const MessageId& latest();
 
     /**
-     * Serialize the message id into a binary string for storing
+     * return is this a chunk message id;
+     */
+    bool isChunkMessageid() const;
+
+    /**
+     * Serialize the message id into a binary string for string

Review comment:
       ```suggestion
        * Serialize the message id into a binary string for storing
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org