You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by techaddict <gi...@git.apache.org> on 2016/05/26 19:36:13 UTC
[GitHub] spark pull request: [SPARK-15576] Add back hive tests blacklisted ...
GitHub user techaddict opened a pull request:
https://github.com/apache/spark/pull/13334
[SPARK-15576] Add back hive tests blacklisted by SPARK-15539
## What changes were proposed in this pull request?
Add back hive tests blacklisted by SPARK-15539
## How was this patch tested?
ran HiveCompatibilitySuite
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/techaddict/spark SPARK-15576
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13334.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13334
----
commit 6361ac5653733f89d9697101a4cac52f17901c61
Author: Sandeep Singh <sa...@techaddict.me>
Date: 2016-05-26T19:34:48Z
[SPARK-15576] Add back hive tests blacklisted by SPARK-15539
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15576] Add back hive tests blacklisted by SPARK-1...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13334
@techaddict please close this PR as this is not the right fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13334: [SPARK-15576] Add back hive tests blacklisted by SPARK-1...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13334
**[Test build #61716 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61716/consoleFull)** for PR 13334 at commit [`30b6012`](https://github.com/apache/spark/commit/30b6012241173b1c395ffce4f0fe375350cd9bb9).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15576] Add back hive tests blacklisted ...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13334#issuecomment-221994991
@techaddict you've misunderstood the JIRA. I removed them from `HiveCompatibilitySuite` on purpose because they don't pass there. Instead you should add them back to `HiveQuerySuite` and fix the usages of `DROP TABLE` there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15576] Add back hive tests blacklisted ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13334#issuecomment-221985150
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59407/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13334: [SPARK-15576] Add back hive tests blacklisted by SPARK-1...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13334
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13334: [SPARK-15576] Add back hive tests blacklisted by ...
Posted by techaddict <gi...@git.apache.org>.
Github user techaddict closed the pull request at:
https://github.com/apache/spark/pull/13334
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13334: [SPARK-15576] Add back hive tests blacklisted by SPARK-1...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13334
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61716/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13334: [SPARK-15576] Add back hive tests blacklisted by SPARK-1...
Posted by techaddict <gi...@git.apache.org>.
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/13334
@andrewor14 ping.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15576] Add back hive tests blacklisted ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13334#issuecomment-221984940
**[Test build #59407 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59407/consoleFull)** for PR 13334 at commit [`6361ac5`](https://github.com/apache/spark/commit/6361ac5653733f89d9697101a4cac52f17901c61).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15576] Add back hive tests blacklisted ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13334#issuecomment-221972267
**[Test build #59407 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59407/consoleFull)** for PR 13334 at commit [`6361ac5`](https://github.com/apache/spark/commit/6361ac5653733f89d9697101a4cac52f17901c61).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13334: [SPARK-15576] Add back hive tests blacklisted by SPARK-1...
Posted by techaddict <gi...@git.apache.org>.
Github user techaddict commented on the issue:
https://github.com/apache/spark/pull/13334
@andrewor14 I've made the changes, can you take a look now ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13334: [SPARK-15576] Add back hive tests blacklisted by ...
Posted by techaddict <gi...@git.apache.org>.
GitHub user techaddict reopened a pull request:
https://github.com/apache/spark/pull/13334
[SPARK-15576] Add back hive tests blacklisted by SPARK-15539
## What changes were proposed in this pull request?
Add back hive tests blacklisted by SPARK-15539
## How was this patch tested?
ran HiveCompatibilitySuite
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/techaddict/spark SPARK-15576
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13334.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13334
----
commit 6361ac5653733f89d9697101a4cac52f17901c61
Author: Sandeep Singh <sa...@techaddict.me>
Date: 2016-05-26T19:34:48Z
[SPARK-15576] Add back hive tests blacklisted by SPARK-15539
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15576] Add back hive tests blacklisted ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13334#issuecomment-221985148
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13334: [SPARK-15576] Add back hive tests blacklisted by SPARK-1...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13334
**[Test build #61716 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61716/consoleFull)** for PR 13334 at commit [`30b6012`](https://github.com/apache/spark/commit/30b6012241173b1c395ffce4f0fe375350cd9bb9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15576] Add back hive tests blacklisted by SPARK-1...
Posted by techaddict <gi...@git.apache.org>.
Github user techaddict closed the pull request at:
https://github.com/apache/spark/pull/13334
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org