You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-user@lucene.apache.org by Stefan Trcek <wz...@abas.de> on 2009/12/01 10:52:41 UTC

Re: What does "out of order" mean?

On Monday 30 November 2009 18:42:50 Michael McCandless wrote:
> I was able to apply that git patch just fine -- so I think it'll
> work?

Good to hear it works that simple.
This patch completes the task.
It is a "two file" patch, so if this will work too, I'm confident.

Stefan

> On Mon, Nov 30, 2009 at 12:22 PM, Stefan Trcek <wz...@abas.de> 
wrote:
> > On Monday 30 November 2009 14:24:20 Michael McCandless wrote:
> >> I agree, it's silly we label things like TopDocs/TopFieldDocs as
> >> expert -- they are no longer for "low level" APIs (or, perhaps
> >> since we've removed the "high level" API (= Hits), what remains
> >> should no longer be considered low level).
> >>
> >> Do you wanna cough up a patch to correct these?

Re: What does "out of order" mean?

Posted by Michael McCandless <lu...@mikemccandless.com>.
OK I committed this, plus further removes of "expert" from TopDocs, to
trunk (future 3.1), 2.9 and 3.0 branches.

Thanks!

Mike

On Tue, Dec 1, 2009 at 5:31 AM, Stefan Trcek <wz...@abas.de> wrote:
> On Tuesday 01 December 2009 11:07:41 Michael McCandless wrote:
>> OK -- none of IndexSearcher's search methods needed tweaking?  Just
>> TopDocs/TopFieldDocs?
>
> Yes, you can use these methods in Searcher, they are sufficient:
>
> TopDocs Searcher.search(Query query, Filter filter, int n)
> TopFieldDocs Searcher.search(Query query, Filter filter, int n, Sort
> sort)
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-user-help@lucene.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-user-help@lucene.apache.org


Re: What does "out of order" mean?

Posted by Michael McCandless <lu...@mikemccandless.com>.
Super, thanks.  I'll commit your patch, fixing javadocs for
TopDocs/TopFieldDocs.

Mike

On Tue, Dec 1, 2009 at 5:31 AM, Stefan Trcek <wz...@abas.de> wrote:
> On Tuesday 01 December 2009 11:07:41 Michael McCandless wrote:
>> OK -- none of IndexSearcher's search methods needed tweaking?  Just
>> TopDocs/TopFieldDocs?
>
> Yes, you can use these methods in Searcher, they are sufficient:
>
> TopDocs Searcher.search(Query query, Filter filter, int n)
> TopFieldDocs Searcher.search(Query query, Filter filter, int n, Sort
> sort)
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-user-help@lucene.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-user-help@lucene.apache.org


Re: What does "out of order" mean?

Posted by Stefan Trcek <wz...@abas.de>.
On Tuesday 01 December 2009 11:07:41 Michael McCandless wrote:
> OK -- none of IndexSearcher's search methods needed tweaking?  Just
> TopDocs/TopFieldDocs?

Yes, you can use these methods in Searcher, they are sufficient:

TopDocs Searcher.search(Query query, Filter filter, int n)
TopFieldDocs Searcher.search(Query query, Filter filter, int n, Sort 
sort)

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-user-help@lucene.apache.org


Re: What does "out of order" mean?

Posted by Michael McCandless <lu...@mikemccandless.com>.
OK -- none of IndexSearcher's search methods needed tweaking?  Just
TopDocs/TopFieldDocs?

Mike

On Tue, Dec 1, 2009 at 4:52 AM, Stefan Trcek <wz...@abas.de> wrote:
> On Monday 30 November 2009 18:42:50 Michael McCandless wrote:
>> I was able to apply that git patch just fine -- so I think it'll
>> work?
>
> Good to hear it works that simple.
> This patch completes the task.
> It is a "two file" patch, so if this will work too, I'm confident.
>
> Stefan
>
>> On Mon, Nov 30, 2009 at 12:22 PM, Stefan Trcek <wz...@abas.de>
> wrote:
>> > On Monday 30 November 2009 14:24:20 Michael McCandless wrote:
>> >> I agree, it's silly we label things like TopDocs/TopFieldDocs as
>> >> expert -- they are no longer for "low level" APIs (or, perhaps
>> >> since we've removed the "high level" API (= Hits), what remains
>> >> should no longer be considered low level).
>> >>
>> >> Do you wanna cough up a patch to correct these?
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-user-help@lucene.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-user-help@lucene.apache.org