You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Benno Evers (Jira)" <ji...@apache.org> on 2019/12/05 15:42:00 UTC
[jira] [Commented] (MESOS-9968) WWWAuthenticate header parsing
fails when commas are in (quoted) realm
[ https://issues.apache.org/jira/browse/MESOS-9968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988921#comment-16988921 ]
Benno Evers commented on MESOS-9968:
------------------------------------
1.8.x:
{noformat}
commit 21ec06ed44c1fbd2272081b20bdcee630759f52d
Author: Benjamin Bannier <bb...@apache.org>
Date: Mon Sep 23 10:24:50 2019 +0200
Fixed parsing of HTTP authentication headers.
This patch adds support for quoted strings in `Www-Authenticate` headers
and allows to use spaces when delimiting authentication attributes of
the form `WWW-Autenticate: a=b, c=d`, both of with are allowed by
RFC2617.
Review: https://reviews.apache.org/r/71534
commit 32d6937bee6c2c43d769daa7b95b33856b9b8364
Author: Benjamin Bannier <bb...@apache.org>
Date: Mon Sep 23 10:23:27 2019 +0200
Cleaned up `HTTPTest.WWWAuthenticateHeader`.
This patch removes a number of error-prone temporaries previously reused
in the test.
Review: https://reviews.apache.org/r/71533
{noformat}
1.9.x
{noformat}
commit 5fa73f683c38c025b0e650de24474e0fdf95d1f4
Author: Benjamin Bannier <bb...@apache.org>
Date: Mon Sep 23 10:24:50 2019 +0200
Fixed parsing of HTTP authentication headers.
This patch adds support for quoted strings in `Www-Authenticate` headers
and allows to use spaces when delimiting authentication attributes of
the form `WWW-Autenticate: a=b, c=d`, both of with are allowed by
RFC2617.
Review: https://reviews.apache.org/r/71534
commit 5f6d218a3123ec35b3a14ce20e72b5ca3594cef2
Author: Benjamin Bannier <bb...@apache.org>
Date: Mon Sep 23 10:23:27 2019 +0200
Cleaned up `HTTPTest.WWWAuthenticateHeader`.
This patch removes a number of error-prone temporaries previously reused
in the test.
Review: https://reviews.apache.org/r/71533
{noformat}
> WWWAuthenticate header parsing fails when commas are in (quoted) realm
> ----------------------------------------------------------------------
>
> Key: MESOS-9968
> URL: https://issues.apache.org/jira/browse/MESOS-9968
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API, libprocess
> Reporter: Jan Schlicht
> Assignee: Benjamin Bannier
> Priority: Major
> Fix For: 1.10.0
>
>
> This was discovered when trying to launch the {{[nvcr.io/nvidia/tensorflow:19.08-py3|http://nvcr.io/nvidia/tensorflow:19.08-py3]}} image using the Mesos containerizer. This launch fails with
> {noformat}
> Failed to launch container: Failed to get WWW-Authenticate header: Unexpected auth-param format: 'realm="https://nvcr.io/proxy_auth?scope=repository:nvidia/tensorflow:pull' in 'realm="https://nvcr.io/proxy_auth?scope=repository:nvidia/tensorflow:pull,push"'
> {noformat}
> This is because the [header tokenization in libprocess|https://github.com/apache/mesos/blob/master/3rdparty/libprocess/src/http.cpp#L640] can't handle commas in quoted realm values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)