You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ppalaga (via GitHub)" <gi...@apache.org> on 2023/06/22 22:21:27 UTC
[GitHub] [camel] ppalaga opened a new pull request, #10476: Newcomer friendly default build, faster fast profile
ppalaga opened a new pull request, #10476:
URL: https://github.com/apache/camel/pull/10476
https://issues.apache.org/jira/browse/CAMEL-19465
https://issues.apache.org/jira/browse/CAMEL-19461
https://issues.apache.org/jira/browse/CAMEL-19466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1605899564
It seems we are using a very old version of the invoker plugin (1.8), released in 2012. I managed to reproduce the problem on my own CI, so now trying a version with invoker 3.6.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1605294978
Another problem I found: `camel-kafka` is running the tests even though `-Dquickly` is being passed. I think that's because we configure the executions for testing backwards compatibility in a separate run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1604481082
mvnd clean install -Dquickly - 03:50 min - first time
mvnd clean install -Dquickly - 03:12 min - second time
mvnd install -Dquickly - 01:00 min - third time
Amazing.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1604251865
### Core test results:
| Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- |
| 1 | 1 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on a diff in pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #10476:
URL: https://github.com/apache/camel/pull/10476#discussion_r1240257242
##########
Jenkinsfile.deploy:
##########
@@ -66,6 +66,10 @@ pipeline {
}
}
steps {
+ // Workaround https://issues.apache.org/jira/browse/INFRA-24713
+ def text = readFile ".mvn/wrapper/maven-wrapper.properties"
+ text.replaceAll("distributionUrl=.*", "https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.8/apache-maven-3.8.8-bin.zip")
+
Review Comment:
Sorry about that. Here is an attempt to fix it: https://github.com/apache/camel/pull/10486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1606856998
The SBOM generation action is not working anymore after this PR. I'll have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1603400932
:leftwards_arrow_with_hook: There are either **too many** changes to be tested in this PR or the code **needs be rebased**: (107 components likely to be affected)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1603385761
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1604453890
> Speaking of improving the build command any reason why not setting `clean install` as `defaultGoal`?
I never use `defaultGoal` because I rarely know what is it for the current project if any at all. I wonder why `install` should be the default goal, rather than anything else? I am just curious how others, who see some value in it, think about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1604251847
:leftwards_arrow_with_hook: There are either **too many** changes to be tested in this PR or the code **needs be rebased**: (107 components likely to be affected)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1604299216
Thanks for testing the alt. platforms, @orpiske !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1604398960
Speaking of improving the build command any reason why not setting `clean install` as `defaultGoal`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga merged pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga merged PR #10476:
URL: https://github.com/apache/camel/pull/10476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1604480088
For example, it is how it is done in Quarkus https://github.com/quarkusio/quarkus/blob/main/pom.xml#L200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a diff in pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #10476:
URL: https://github.com/apache/camel/pull/10476#discussion_r1240162673
##########
Jenkinsfile.deploy:
##########
@@ -66,6 +66,10 @@ pipeline {
}
}
steps {
+ // Workaround https://issues.apache.org/jira/browse/INFRA-24713
+ def text = readFile ".mvn/wrapper/maven-wrapper.properties"
+ text.replaceAll("distributionUrl=.*", "https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.8/apache-maven-3.8.8-bin.zip")
+
Review Comment:
This approach did not work for our CI. The snapshot deployment is failing again: https://ci-builds.apache.org/job/Camel/job/Camel%20Daily%20Snapshot%20Deploy/job/main/363/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1604234781
9e53ff8:
* Rabased
* Added "Workaround INFRA-24713 in the deploy script" https://github.com/apache/camel/pull/10476/commits/a3242d199bb3359253f6b010905701a4b6cfe8e3
* Added "Adapt CI scripts to new fast profile and..." https://github.com/apache/camel/pull/10476/commits/9e53ff8c3b76fef110b6f98b3282910e886bc2de
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1605284300
Just bringing a separate discussion here, as more people are subscribed to this thread.
Looking at the CI jobs we have:
- Deployment job has progressed a bit. There seems to be something strange on `camel-xml-io` preventing it from [going further](https://ci-builds.apache.org/job/Camel/job/Camel%20Daily%20Snapshot%20Deploy/job/main/368/console) and also with `camel-package-maven-plugin` ([same one causing problem on the main build](https://ci-builds.apache.org/job/Camel/job/Camel%20JDK17/job/main/951/console)).
I do not have these problems on my own CI, which is very similar to the ASF one, so I think we are close to having the builds passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1606854737
So, current status for our builds is:
* Snapshot deploy: last build went as far as 95% of the build. I fixed it earlier today and a new build is in progress. Hopefully that will complete.
* JDK 17 build: currently hangs on the core tests. I don't think it's related to this patch, as this is a known issue (I am currently investigating this).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1603400940
### Core test results:
| Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- |
| 1 | 1 | 0 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1603864474
Overall LGTM. I'm going to do a few manual tests on different archs to double check if everything is alright on ARM and s390x - not concerned, it should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1604005112
> I'm going to do a few manual tests on different archs to double check if everything is alright on ARM and s390x
That's great, thanks a lot, @orpiske!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1604478960
Because 99% of the time maven users usually launch the command `mvn clean install..." like it is describe in the contributing guide https://camel.apache.org/community/contributing/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ppalaga commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1604724515
> Because 99% of the time maven users usually launch the command `mvn clean install..." like it is described in the contributing guide https://camel.apache.org/community/contributing/
Sounds legit, thanks for explaining @essobedo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10476: Newcomer friendly default build, faster fast profile
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10476:
URL: https://github.com/apache/camel/pull/10476#issuecomment-1605919621
> It seems we are using a very old version of the invoker plugin (1.8), released in 2012. I managed to reproduce the problem on my own CI, so now trying a version with invoker 3.6.0.
Upgrading seems to have helped. It now fails on `camel-util` because `maven-source-plugin` is defined twice when use the `deploy` profile. I think we can remove that, as attaching the sources can be done using the `source-jar` or `deploy` profiles (and, likely, not necessary during regular build).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org