You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/06/04 17:14:29 UTC

[GitHub] [solr] cpoerschke opened a new pull request #163: SOLR-15454, SOLR-14920: remove Lucene commits from .git-blame-ignore-revs and add Solr commits placeholder

cpoerschke opened a new pull request #163:
URL: https://github.com/apache/solr/pull/163


   https://issues.apache.org/jira/browse/SOLR-15454
   
   (Straightforward change but pull request for visibility/transparency. Approve-and-merge in one step welcome. Thank you.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] cpoerschke merged pull request #163: SOLR-15454: retain and explain Lucene commits in .git-blame-ignore-revs

Posted by GitBox <gi...@apache.org>.
cpoerschke merged pull request #163:
URL: https://github.com/apache/solr/pull/163


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] cpoerschke commented on a change in pull request #163: SOLR-15454, SOLR-14920: remove Lucene commits from .git-blame-ignore-revs and add Solr commits placeholder

Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #163:
URL: https://github.com/apache/solr/pull/163#discussion_r646921829



##########
File path: .git-blame-ignore-revs
##########
@@ -1,6 +1,2 @@
-# LUCENE-9570 [google java formatter applied]
-6faa4f98e04817bf27d02d96332904a29fb7db69
-2d6ad2fee6dfd96388594f4de9b37c037efe8017
-8ef6a0da56878177ff8d6880c92e8f7d0321d076
-7f8b7ffbcad2265b047a5e2195f76cc924028063
-2cbf261032dc8aca56c846971c090c991ac594a6
+# SOLR-14920 [google java formatter applied]
+# please add here

Review comment:
       ```suggestion
   # SOLR-14920 [google java formatter applied]
   # please add here
   ```
   
   outscoping placeholder addition as per https://issues.apache.org/jira/browse/SOLR-14920?focusedCommentId=17358852&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17358852 context




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] cpoerschke commented on a change in pull request #163: SOLR-15454, SOLR-14920: remove Lucene commits from .git-blame-ignore-revs and add Solr commits placeholder

Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #163:
URL: https://github.com/apache/solr/pull/163#discussion_r646921829



##########
File path: .git-blame-ignore-revs
##########
@@ -1,6 +1,2 @@
-# LUCENE-9570 [google java formatter applied]
-6faa4f98e04817bf27d02d96332904a29fb7db69
-2d6ad2fee6dfd96388594f4de9b37c037efe8017
-8ef6a0da56878177ff8d6880c92e8f7d0321d076
-7f8b7ffbcad2265b047a5e2195f76cc924028063
-2cbf261032dc8aca56c846971c090c991ac594a6
+# SOLR-14920 [google java formatter applied]
+# please add here

Review comment:
       ```suggestion
   ```
   
   outscoping placeholder addition as per https://issues.apache.org/jira/browse/SOLR-14920?focusedCommentId=17358852&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17358852 context




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org