You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/03/07 18:54:18 UTC

Review Request 31828: Upgrade gradle and a few plugins.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31828/
-----------------------------------------------------------

Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
-------

Gradle 2.3: http://gradle.org/docs/2.3/release-notes
Checkstyle: http://checkstyle.sourceforge.net/releasenotes.html
Can't tell what, if anything, changed in the versions plugin: https://github.com/ben-manes/gradle-versions-plugin/releases


Diffs
-----

  build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 
  buildSrc/gradle.properties 73341fa90f20d73edf34fc3c945b686dd14bf941 
  gradle/wrapper/gradle-wrapper.jar 2322723c7ed5f591adfa4c87b6c51932f591249a 
  gradle/wrapper/gradle-wrapper.properties 531b41ced8b99d418636a18f4f97297722944ea3 

Diff: https://reviews.apache.org/r/31828/diff/


Testing
-------


Thanks,

Bill Farner


Re: Review Request 31828: Upgrade gradle and a few plugins.

Posted by Bill Farner <wf...@apache.org>.

> On March 9, 2015, 5:58 p.m., Kevin Sweeney wrote:
> > LGTM once reviewbot is happy. It might be choking on the binary diff.

Yeah, pretty sure that's the case :-(


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31828/#review75729
-----------------------------------------------------------


On March 7, 2015, 5:54 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31828/
> -----------------------------------------------------------
> 
> (Updated March 7, 2015, 5:54 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Gradle 2.3: http://gradle.org/docs/2.3/release-notes
> Checkstyle: http://checkstyle.sourceforge.net/releasenotes.html
> Can't tell what, if anything, changed in the versions plugin: https://github.com/ben-manes/gradle-versions-plugin/releases
> 
> 
> Diffs
> -----
> 
>   build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 
>   buildSrc/gradle.properties 73341fa90f20d73edf34fc3c945b686dd14bf941 
>   gradle/wrapper/gradle-wrapper.jar 2322723c7ed5f591adfa4c87b6c51932f591249a 
>   gradle/wrapper/gradle-wrapper.properties 531b41ced8b99d418636a18f4f97297722944ea3 
> 
> Diff: https://reviews.apache.org/r/31828/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 31828: Upgrade gradle and a few plugins.

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31828/#review75729
-----------------------------------------------------------

Ship it!


LGTM once reviewbot is happy. It might be choking on the binary diff.

- Kevin Sweeney


On March 7, 2015, 9:54 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31828/
> -----------------------------------------------------------
> 
> (Updated March 7, 2015, 9:54 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Gradle 2.3: http://gradle.org/docs/2.3/release-notes
> Checkstyle: http://checkstyle.sourceforge.net/releasenotes.html
> Can't tell what, if anything, changed in the versions plugin: https://github.com/ben-manes/gradle-versions-plugin/releases
> 
> 
> Diffs
> -----
> 
>   build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 
>   buildSrc/gradle.properties 73341fa90f20d73edf34fc3c945b686dd14bf941 
>   gradle/wrapper/gradle-wrapper.jar 2322723c7ed5f591adfa4c87b6c51932f591249a 
>   gradle/wrapper/gradle-wrapper.properties 531b41ced8b99d418636a18f4f97297722944ea3 
> 
> Diff: https://reviews.apache.org/r/31828/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 31828: Upgrade gradle and a few plugins.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31828/#review75639
-----------------------------------------------------------


This patch does not apply cleanly on master (fdc11e3), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 7, 2015, 5:54 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31828/
> -----------------------------------------------------------
> 
> (Updated March 7, 2015, 5:54 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Gradle 2.3: http://gradle.org/docs/2.3/release-notes
> Checkstyle: http://checkstyle.sourceforge.net/releasenotes.html
> Can't tell what, if anything, changed in the versions plugin: https://github.com/ben-manes/gradle-versions-plugin/releases
> 
> 
> Diffs
> -----
> 
>   build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 
>   buildSrc/gradle.properties 73341fa90f20d73edf34fc3c945b686dd14bf941 
>   gradle/wrapper/gradle-wrapper.jar 2322723c7ed5f591adfa4c87b6c51932f591249a 
>   gradle/wrapper/gradle-wrapper.properties 531b41ced8b99d418636a18f4f97297722944ea3 
> 
> Diff: https://reviews.apache.org/r/31828/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>