You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/06 11:28:02 UTC
[GitHub] [spark] cloud-fan commented on a diff in pull request #38899: [SPARK-41349][CONNECT] Implement DataFrame.hint
cloud-fan commented on code in PR #38899:
URL: https://github.com/apache/spark/pull/38899#discussion_r1040849638
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -694,6 +685,18 @@ package object dsl {
.build()
}
+ def hint(name: String, parameters: Any*): Relation = {
+ Relation
+ .newBuilder()
+ .setHint(
+ Hint
Review Comment:
hmm, the proto message `Hint` was added before this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org