You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by st...@apache.org on 2025/04/12 10:33:13 UTC
(felix-dev) 04/19: [framework] Remove redundant String.substring() parameter
This is an automated email from the ASF dual-hosted git repository.
stbischof pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/felix-dev.git
commit 77c319337038edb1cd6b4b44bd7339609b306fe3
Author: Stefan Bischof <st...@bipolis.org>
AuthorDate: Sat Apr 5 09:00:34 2025 +0200
[framework] Remove redundant String.substring() parameter
Signed-off-by: Stefan Bischof <st...@bipolis.org>
---
framework/src/main/java/org/apache/felix/framework/util/Util.java | 2 +-
.../felix/framework/util/manifestparser/NativeLibraryClause.java | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/framework/src/main/java/org/apache/felix/framework/util/Util.java b/framework/src/main/java/org/apache/felix/framework/util/Util.java
index ee2545286e..637417ad36 100644
--- a/framework/src/main/java/org/apache/felix/framework/util/Util.java
+++ b/framework/src/main/java/org/apache/felix/framework/util/Util.java
@@ -819,7 +819,7 @@ public class Util
// value.
val = val.substring(0, startDelim)
+ substValue
- + val.substring(stopDelim + DELIM_STOP.length(), val.length());
+ + val.substring(stopDelim + DELIM_STOP.length());
// Now perform substitution again, since there could still
// be substitutions to make.
diff --git a/framework/src/main/java/org/apache/felix/framework/util/manifestparser/NativeLibraryClause.java b/framework/src/main/java/org/apache/felix/framework/util/manifestparser/NativeLibraryClause.java
index 76f8d5f8e9..fef8ed7036 100644
--- a/framework/src/main/java/org/apache/felix/framework/util/manifestparser/NativeLibraryClause.java
+++ b/framework/src/main/java/org/apache/felix/framework/util/manifestparser/NativeLibraryClause.java
@@ -426,8 +426,7 @@ public class NativeLibraryClause
{
property = (token.substring(0, token.indexOf("=")))
.trim().toLowerCase();
- value = (token.substring(token.indexOf("=") + 1, token
- .length())).trim();
+ value = (token.substring(token.indexOf("=") + 1)).trim();
}
// Values may be quoted, so remove quotes if present.
@@ -758,7 +757,7 @@ public class NativeLibraryClause
{
String s = value.substring(1, value.length() - 1);
String vlo = s.substring(0, s.indexOf(',')).trim();
- String vhi = s.substring(s.indexOf(',') + 1, s.length()).trim();
+ String vhi = s.substring(s.indexOf(',') + 1).trim();
return new VersionRange(value.charAt(0), toOsgiVersion(vlo), toOsgiVersion(vhi),
value.charAt(value.length() - 1)).toString();
}