You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/10/22 10:52:06 UTC
[PR] Route shell failure diagnostics to stderr [shardingsphere]
terrymanu opened a new pull request, #40334:
URL: https://github.com/apache/shardingsphere/pull/40334
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Route shell failure diagnostics to stderr [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #40334:
URL: https://github.com/apache/shardingsphere/pull/40334#issuecomment-6338980207
### Result
Review Result: Mergeable
No blocking issues or recommended changes remain.
### Evidence
- All four failure branches produce empty stdout, preserve the exact diagnostic messages on stderr, and still exit with code 1.
- All 167 matrix assertions and three shell syntax checks passed.
- Stubbed MySQL checks confirmed unchanged normal execution and failure-code propagation.
### Coverage
Standalone local candidate based on 27591ff6ad62.
Reviewed all four changes in the two authorized scripts and their callers.
Two independent assessments completed all three review lenses and convergence, followed by coordinator verification and session validation.
Spotless and Checkstyle do not apply to these Shell files; RAT was not triggered.
This conclusion covers code correctness only; remote CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Route shell failure diagnostics to stderr [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #40334:
URL: https://github.com/apache/shardingsphere/pull/40334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org