You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by etengabeko <gi...@git.apache.org> on 2018/02/21 11:08:44 UTC
[GitHub] qpid-cpp pull request #11: Fix build on Windows
GitHub user etengabeko opened a pull request:
https://github.com/apache/qpid-cpp/pull/11
Fix build on Windows
Expression PODMutex m = QPID_MUTEX_INITIALIZER not compiled by Visual Studio with error:
error C2440: 'initializing' : cannot convert from 'int' to 'qpid::sys::PODMutex'
Add implicit initializing for type PODMutex.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/etengabeko/qpid-cpp master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-cpp/pull/11.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11
----
commit ecf2b61f6faf7bde4b3c0d25d85b7d9951e7d708
Author: aleks.andr <pk...@...>
Date: 2018-02-21T11:07:43Z
Fix build expression: PODMutex m = QPID_MUTEX_INITIALIZER; on Windows
Expression PODMutex m = QPID_MUTEX_INITIALIZER not compiled by Visual Studio with error:
error C2440: 'initializing' : cannot convert from 'int' to 'qpid::sys::PODMutex'
Add implicit initializing for type PODMutex.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-cpp pull request #11: Fix build on Windows
Posted by etengabeko <gi...@git.apache.org>.
Github user etengabeko closed the pull request at:
https://github.com/apache/qpid-cpp/pull/11
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-cpp issue #11: Fix build on Windows
Posted by etengabeko <gi...@git.apache.org>.
Github user etengabeko commented on the issue:
https://github.com/apache/qpid-cpp/pull/11
I am agree. I only registered the problem and added temporary patch for fix it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-cpp issue #11: Fix build on Windows
Posted by alanconway <gi...@git.apache.org>.
Github user alanconway commented on the issue:
https://github.com/apache/qpid-cpp/pull/11
Thanks a lot for that! It helped clarify the problem.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-cpp issue #11: Fix build on Windows
Posted by alanconway <gi...@git.apache.org>.
Github user alanconway commented on the issue:
https://github.com/apache/qpid-cpp/pull/11
The fix would work but I'd prefer to get rid of the bogus assignment rather than add a dummy constructor to hide it. I've put up pull request #13 that does that.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org