You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "hxmhlt (GitHub)" <gi...@apache.org> on 2020/02/16 08:10:46 UTC
[GitHub] [dubbo-go] hxmhlt opened pull request #359: Mod zk listen
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
[ Full content available at: https://github.com/apache/dubbo-go/pull/359 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #359: Mod:cancel
listener dir when zkpath end of providers/ & consumers/
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=h1) Report
> Merging [#359](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/d0d3ac1985a2da5a9e03b662ff5c320aa4a2f1ea?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #359 +/- ##
==========================================
+ Coverage 66.74% 66.8% +0.05%
==========================================
Files 150 150
Lines 7936 7938 +2
==========================================
+ Hits 5297 5303 +6
+ Misses 2137 2134 -3
+ Partials 502 501 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/359/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `63.46% <100%> (ø)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/359/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `52.57% <100%> (+0.54%)` | :arrow_up: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/359/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `72.03% <0%> (+3.38%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=footer). Last update [d0d3ac1...e501e80](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/359 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #359: Mod:cancel
listener dir when zkpath end of providers/ & consumers/
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=h1) Report
> Merging [#359](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/d0d3ac1985a2da5a9e03b662ff5c320aa4a2f1ea?src=pr&el=desc) will **decrease** coverage by `0.16%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #359 +/- ##
===========================================
- Coverage 66.74% 66.57% -0.17%
===========================================
Files 150 150
Lines 7936 7938 +2
===========================================
- Hits 5297 5285 -12
- Misses 2137 2149 +12
- Partials 502 504 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/359/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `52.57% <100%> (+0.54%)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/359/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `35.29% <0%> (-29.42%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/359/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/359/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0%> (-1.71%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=footer). Last update [d0d3ac1...e501e80](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/359 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #359: Mod:cancel
listener dir when zkpath end of providers/ & consumers/
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=h1) Report
> Merging [#359](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/d0d3ac1985a2da5a9e03b662ff5c320aa4a2f1ea?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #359 +/- ##
==========================================
+ Coverage 66.74% 66.8% +0.05%
==========================================
Files 150 150
Lines 7936 7938 +2
==========================================
+ Hits 5297 5303 +6
+ Misses 2137 2134 -3
+ Partials 502 501 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/359/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `63.46% <100%> (ø)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/359/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `52.57% <100%> (+0.54%)` | :arrow_up: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/359/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `72.03% <0%> (+3.38%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=footer). Last update [d0d3ac1...5db9bdd](https://codecov.io/gh/apache/dubbo-go/pull/359?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/359 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] pantianying closed pull request #359: Mod:cancel
listener dir when zkpath end of providers/ & consumers/
Posted by "pantianying (GitHub)" <gi...@apache.org>.
[ pull request closed by pantianying ]
[ Full content available at: https://github.com/apache/dubbo-go/pull/359 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] hxmhlt commented on pull request #359: Mod:cancel
listener dir when zkpath end of providers/ & consumers/
Posted by "hxmhlt (GitHub)" <gi...@apache.org>.
Be same as other func. GetMetricConfig / GetApplicationConfig
[ Full content available at: https://github.com/apache/dubbo-go/pull/359 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org