You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by ueshin <gi...@git.apache.org> on 2018/12/03 05:19:53 UTC

[GitHub] spark pull request #22512: [SPARK-25498][SQL] InterpretedMutableProjection s...

Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22512#discussion_r238146834
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedMutableProjection.scala ---
    @@ -64,7 +85,7 @@ class InterpretedMutableProjection(expressions: Seq[Expression]) extends Mutable
         i = 0
         while (i < validExprs.length) {
           val (_, ordinal) = validExprs(i)
    -      mutableRow(ordinal) = buffer(ordinal)
    +      fieldWriters(i)(buffer(ordinal))
    --- End diff --
    
    Since `fieldWriters` is accessed via index, we should use `IndexedSeq` or `Array` explicitly?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org