You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/03/23 08:05:54 UTC

[GitHub] [rocketmq] YJFinBJ opened a new issue #1877: Rocketmq heavily use NetworkInterface to get ip which is not recommended use in kubernates

YJFinBJ opened a new issue #1877: Rocketmq heavily use NetworkInterface to get ip which is not recommended use in kubernates
URL: https://github.com/apache/rocketmq/issues/1877
 
 
   rocketmq use NetworkInterface.getNetworkInterfaces() to getIp in many places, for example,  in  brokerlive cache, in store msg used as msg tag, etc.  As Cloud Native standard and kubernates is popular more and more，in which “ip” is not recommended use, while dns is the mainstream. So,
   why rocketmq not decouple these "ip"  hard coded by NetworkInterface.getNetworkInterfaces(),other than make it configurable(ip or dns or any other form),  if possible.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] YJFinBJ commented on issue #1877: Rocketmq heavily use NetworkInterface to get ip which is not recommended use in kubernates

Posted by GitBox <gi...@apache.org>.

YJFinBJ commented on issue #1877: Rocketmq heavily use NetworkInterface to get ip which is not recommended use in kubernates
URL: https://github.com/apache/rocketmq/issues/1877#issuecomment-603592547
 
 
   since ip is marked as a tag for broker, and in cloud native, in k8s ,broker usually is set by statefulset, which we can use name+namespace as the unique tag, just like xx-xx-0-ns1, yy-yy-0-ns2. so we can configure it in our own broker statefulset, and that's the unique tag in k8s just as the "ip" in vm or node

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] duhenglucky commented on issue #1877: Rocketmq heavily use NetworkInterface to get ip which is not recommended use in kubernates

Posted by GitBox <gi...@apache.org>.

duhenglucky commented on issue #1877: Rocketmq heavily use NetworkInterface to get ip which is not recommended use in kubernates
URL: https://github.com/apache/rocketmq/issues/1877#issuecomment-603656199
 
 
   @YJFinBJ good suggestions, but IP is used throughout RocketMQ as a unique identifier, including client differentiation (this is reflected in many issues), message storage formats(IPv4&IPv6), etc. This does cause a lot of issues in the container environment, so there is very much of the work that needs to be done, such as the compatibility of the non-k8s environment that also needs to be considered. 
   
   This change seems to be relatively large, so could you provide a more detailed design first so that more users from the community can participate?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] RongtongJin commented on issue #1877: Rocketmq heavily use NetworkInterface to get ip which is not recommended use in kubernates

Posted by GitBox <gi...@apache.org>.

RongtongJin commented on issue #1877: Rocketmq heavily use NetworkInterface to get ip which is not recommended use in kubernates
URL: https://github.com/apache/rocketmq/issues/1877#issuecomment-603117398
 
 
   Good suggestion. RocketMQ is embracing cloud native, as you said, there are some issues at present, so PRs are welcomed to solve these issues.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] YJFinBJ commented on issue #1877: Rocketmq heavily use NetworkInterface to get ip which is not recommended use in kubernates

Posted by GitBox <gi...@apache.org>.

YJFinBJ commented on issue #1877: Rocketmq heavily use NetworkInterface to get ip which is not recommended use in kubernates
URL: https://github.com/apache/rocketmq/issues/1877#issuecomment-607670418
 
 
   about compatibility of non-k8s environment , I think make it configurable can resolve，default non-k8s support。
   
   But just as mentioned, this does a really large work,  detailed design and also enough test needed, I think

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] RongtongJin commented on issue #1877: Rocketmq heavily use NetworkInterface to get ip which is not recommended use in kubernates

Posted by GitBox <gi...@apache.org>.

RongtongJin commented on issue #1877: Rocketmq heavily use NetworkInterface to get ip which is not recommended use in kubernates
URL: https://github.com/apache/rocketmq/issues/1877#issuecomment-608412338
 
 
   Hi @YJFinBJ YJ you can submit a [RIP](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal) if you have enough time to slove this issue. I am willing to be a shepherd for the RIP and solve this issue with you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] duhenglucky edited a comment on issue #1877: Rocketmq heavily use NetworkInterface to get ip which is not recommended use in kubernates

Posted by GitBox <gi...@apache.org>.

duhenglucky edited a comment on issue #1877: Rocketmq heavily use NetworkInterface to get ip which is not recommended use in kubernates
URL: https://github.com/apache/rocketmq/issues/1877#issuecomment-603656199
 
 
   @YJFinBJ good suggestions, but IP is used throughout RocketMQ as a unique identifier, including client differentiation (this is reflected in many issues), message storage formats(IPv4&IPv6), etc. This does cause a lot of issues in the container environment, so there is very much work that needs to be done, such as the compatibility of the non-k8s environment that also needs to be considered. 
   
   This change seems to be relatively large, so could you provide a more detailed design first so that more users from the community can participate?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services