You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by madhawa-gunasekara <gi...@git.apache.org> on 2017/05/10 10:50:12 UTC

[GitHub] gora pull request #101: GORA-310: Fix partial field delete in solr

GitHub user madhawa-gunasekara opened a pull request:

    https://github.com/apache/gora/pull/101

    GORA-310: Fix partial field delete in solr

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/madhawa-gunasekara/gora GORA-310

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #101
    
----
commit 8015966f09b765fdda64ced7dc16395da3b57d04
Author: madhawa-gunasekara <ma...@wso2.com>
Date:   2017-05-10T10:47:36Z

    GORA-310: Fix partial field delete in solr

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #101: GORA-310: Fix partial field deletion in solr documents

Posted by djkevincr <gi...@git.apache.org>.
Github user djkevincr commented on the issue:

    https://github.com/apache/gora/pull/101
  
    +1 from my end, if no objections will go ahead and merge to master :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #101: GORA-310: Fix partial field deletion in solr documen...

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/gora/pull/101#discussion_r115810858
  
    --- Diff: gora-solr-5/src/main/java/org/apache/gora/solr/store/SolrStore.java ---
    @@ -17,11 +17,7 @@
     import java.io.IOException;
     import java.net.MalformedURLException;
     import java.nio.ByteBuffer;
    -import java.util.ArrayList;
    -import java.util.List;
    -import java.util.Locale;
    -import java.util.Map;
    -import java.util.Properties;
    +import java.util.*;
    --- End diff --
    
    Yes please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #101: GORA-310: Fix partial field deletion in solr documen...

Posted by madhawa-gunasekara <gi...@git.apache.org>.
Github user madhawa-gunasekara commented on a diff in the pull request:

    https://github.com/apache/gora/pull/101#discussion_r115813417
  
    --- Diff: gora-solr-5/src/main/java/org/apache/gora/solr/store/SolrStore.java ---
    @@ -17,11 +17,7 @@
     import java.io.IOException;
     import java.net.MalformedURLException;
     import java.nio.ByteBuffer;
    -import java.util.ArrayList;
    -import java.util.List;
    -import java.util.Locale;
    -import java.util.Map;
    -import java.util.Properties;
    +import java.util.*;
    --- End diff --
    
    Sure I will modify the pull request. +1 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #101: GORA-310: Fix partial field deletion in solr documents

Posted by madhawa-gunasekara <gi...@git.apache.org>.
Github user madhawa-gunasekara commented on the issue:

    https://github.com/apache/gora/pull/101
  
    @lewismc @djkevincr 
    
    I have updated the pull request with the suggestions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #101: GORA-310: Fix partial field deletion in solr documen...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/gora/pull/101


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #101: GORA-310: Fix partial field deletion in solr documen...

Posted by djkevincr <gi...@git.apache.org>.
Github user djkevincr commented on a diff in the pull request:

    https://github.com/apache/gora/pull/101#discussion_r115805147
  
    --- Diff: gora-solr-5/src/main/java/org/apache/gora/solr/store/SolrStore.java ---
    @@ -17,11 +17,7 @@
     import java.io.IOException;
     import java.net.MalformedURLException;
     import java.nio.ByteBuffer;
    -import java.util.ArrayList;
    -import java.util.List;
    -import java.util.Locale;
    -import java.util.Map;
    -import java.util.Properties;
    +import java.util.*;
    --- End diff --
    
    Shall we do this imports separately?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #101: GORA-310: Fix partial field deletion in solr documents

Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the issue:

    https://github.com/apache/gora/pull/101
  
    👍 looks good @madhawa-gunasekara  thanks all!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---