[GitHub] [geode] upthewaterspout opened pull request #2568: GEODE-5811: Get gradle to cache tomcat and jetty installs

["upthewaterspout (GitHub)" <gi...@apache.org>]

We were downloading full installs of tomcat and jetty on every test run.
This occasionally resulted in test failures if the download site was
down. Now we get this installs as gradle dependencies, which will be
cached.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2568 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] upthewaterspout commented on pull request #2568: GEODE-5811: Get gradle to cache tomcat and jetty installs

["upthewaterspout (GitHub)" <gi...@apache.org>]

Good point. I switched to using depency-versions.properties and now we are using consistent versions of tomcat. Thanks!

[ Full content available at: https://github.com/apache/geode/pull/2568 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] upthewaterspout closed pull request #2568: GEODE-5811: Get gradle to cache tomcat and jetty installs

["upthewaterspout (GitHub)" <gi...@apache.org>]

[ pull request closed by upthewaterspout ]

[ Full content available at: https://github.com/apache/geode/pull/2568 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on pull request #2568: GEODE-5811: Get gradle to cache tomcat and jetty installs

["PurelyApplied (GitHub)" <gi...@apache.org>]

For consistency, these versions should make sure of the project properties present in `dependency-versions.properties`, e.g.,
```
  webServerJetty group: 'org.eclipse.jetty', name: 'jetty-distribution', version: project.'jetty.version', ext: 'zip'
```

I note that neither of these Tomcat7 versions match that which we define in our dependency versions file, which should be updated to reflect actual consumption.

[ Full content available at: https://github.com/apache/geode/pull/2568 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org